Skip to content

Conversation

michaellee1019
Copy link
Member

@michaellee1019 michaellee1019 commented Oct 15, 2025

This is a pretty large PR, but all changes are cohesive together and hard to break apart into separate PRs.

The changes focus on hot reloading, as well as other commands that do package updates and shell copies. All are changed together so that the package and shell utilities can be compatible with better progress indicators.

  • I chose the library github.com/chelnak/ysmrr as it seems like the best golang option for multi-step progress with support to nest some steps inside of others. I know the CLI generator uses huh but it does not provide the same features such as multiple steps (on different lines) and step nesting. Maybe a separate task could be done to use this new dependency on the generator side.
  • I made a utility to handle progress tracking across the codebase and called it ProgressManager. Without it the code was gross and had too much state progress management throughout the code.
  • I removed some conflicting error messages, changed the file copier to report its progress as a spinner instead of a log message.
  • I also refactored the code so that the binary download step actually happens as a post-build step in the code flow.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants