module reload improvements #5370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
stuqdog
commented
Oct 13, 2025
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
michaellee1019
approved these changes
Oct 14, 2025
Comment on lines
+3050
to
+3060
| # A full reload command. This will build your module, send the tarball to the machine with given part ID, | ||
| # and configure or restart it. | ||
| viam module reload --part-id UUID | ||
| # Run viam module reload on a mac and use the downloaded viam.json file instead of --part-id | ||
| viam module reload --cloud-config ~/Downloads/viam-mac-main.json | ||
| # Specify a component/service model (and optionally a name) to add to the config along with | ||
| # the module (the API is automatically looked up from meta.json) | ||
| # By default, no resources are added when a module is reloaded | ||
| viam module reload --model-name acme:module-name:mybase --name my-resource`, |
cli/module_build.go
Outdated
| return org.GetId(), nil | ||
| } | ||
|
|
||
| func (c *viamClient) triggerCloudReload( |
There was a problem hiding this comment.
nit: I read this initially and expected the entire flow for reload here. Then realized it was just the build trigger.
Suggested change
| func (c *viamClient) triggerCloudReload( | |
| func (c *viamClient) triggerCloudReloadBuild( |
…064-module-reload-improvements
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
michaellee1019
approved these changes
Oct 17, 2025
njooma
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test failures are expected until the API PR is merged because we're referencing proto types that don't technically exist yet.