RSDK-10245 Use VIAM_MODULE_NAME as logger name for golang module loggers #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
benjirewis
commented
Mar 12, 2025
| // string if not specified in environment.) | ||
| if moduleName == "" { | ||
| moduleName, _ = os.LookupEnv("VIAM_MODULE_NAME") | ||
| } |
There was a problem hiding this comment.
There were a couple different ways to do this. Both ModularMain and NewModuleFromArgs call NewLoggerFromArgs(""), so this is what I chose to do. Could also pass in VIAM_MODULE_NAME to NewLoggerFromArgs from both those call sites. Don't want to break any of this module API though for existing modules (e.g. not take in a moduleName parameter to this function.)
There was a problem hiding this comment.
sgtm, maybe add something to the comment saying this will happen?
cheukt
approved these changes
Mar 12, 2025
| // string if not specified in environment.) | ||
| if moduleName == "" { | ||
| moduleName, _ = os.LookupEnv("VIAM_MODULE_NAME") | ||
| } |
There was a problem hiding this comment.
sgtm, maybe add something to the comment saying this will happen?
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-10245
Uses
VIAM_MODULE_NAMEas the logger name for loggers created throughNewLoggerFromArgsif passed inmoduleNameis"".Golang modular resource logs that used to look like:
now look like: