RSDK-6155 - add initialDialAttempts to robot client options #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
a team,
njooma and
lia-viam
and removed request for
a team
viambot
added
the
safe to test
viambot
added
safe to test
njooma
reviewed
Mar 10, 2025
njooma
requested changes
Mar 10, 2025
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
njooma
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
initialDialAttemptsto robot client options, to indicate the number of attempts when initially dialing.I opted not to include a timeout, under the thinking that adding a timeout to a context is the more idiomatic way to work with timeouts in go (and is already respected by the
dialfunc in goutils).