[RSDK-9655] skip reflection for discovery service and add fake discovery #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
cheukt
reviewed
Jan 9, 2025
module/module_test.go
Outdated
Comment on lines
153
to
157
| // discoveryConf := &v1.ComponentConfig{ | ||
| // Name: "mydis1", | ||
| // Api: "rdk:service:discovery", | ||
| // Model: "acme:demo:mydiscovery", | ||
| // } |
| } | ||
| // due to how tagger is setup in the api we cannot use reflection on the discovery service currently | ||
| // for now we will skip the reflection step for discovery until the issue is resolved. | ||
| if api != discovery.API { |
There was a problem hiding this comment.
did you check that the test would fail if this block is not in?
There was a problem hiding this comment.
yep we get theSymbol Not Founderror
There was a problem hiding this comment.
Should we add a ticket and a TODO?
There was a problem hiding this comment.
added a ticket+TODO comment https://viam.atlassian.net/browse/RSDK-9718
viambot
added
safe to test
viambot
added
safe to test
randhid
approved these changes
Jan 10, 2025
| } | ||
| // due to how tagger is setup in the api we cannot use reflection on the discovery service currently | ||
| // for now we will skip the reflection step for discovery until the issue is resolved. | ||
| if api != discovery.API { |
There was a problem hiding this comment.
Should we add a ticket and a TODO?
martha-johnston
approved these changes
Jan 10, 2025
viambot
added
safe to test
Co-authored-by: martha-johnston <[email protected]> Co-authored-by: randhid <[email protected]>
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-9655
in order to get around the tagger/proto reflection issue we saw when using the discovery service with modules, we are now skipping the reflection step for discovery apis, and relying on the builtin fake discovery service to register the proto definition.
tested with a module that implements a discover service and some client code