-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-9440 Report machine state
through GetMachineStatus
#4616
Merged
+585
−180
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
9026f00
initial impl
benjirewis 53b9d29
atomic
benjirewis 4802b8d
start config watcher goroutine last
benjirewis 8fa9830
addrderef -> CopyOnlyPublicFields
benjirewis c78e16e
update api dependency and lint
benjirewis 62c3f5e
more lint sigh
benjirewis 3b9d6b9
basic entrypoint test
benjirewis d97e583
reconfigure in goroutine and check for state running in client new
benjirewis 58b4b94
typos
benjirewis eacd561
client test inject fixes
benjirewis 4948b13
move out of initializing in setupLocalRobot
benjirewis d756396
add log lines for debugging 32 bit tests
benjirewis fcf03b5
move running check higher
benjirewis 09b76fd
potentially simpler API
benjirewis 35f8f3d
more missing injections
benjirewis e299ab4
fix more tests sigh
benjirewis 19f7940
maybe this time
benjirewis d68e6f4
actually use value from options
benjirewis 2d8bc1b
make configWatcher a method instead of an anonymous function
benjirewis f997bbb
put back lints
benjirewis f97feef
try to simplify updateWeakDependents check in completeConfig
benjirewis 72bada6
avoid CopyOnlyPublicFields
benjirewis fc67364
initializing -> running test
benjirewis 18555b3
move redefinition of context above slow shutdown goroutine
benjirewis e46aa9d
remove debug logs
benjirewis 7f0fffd
table drive and fix server GetMachineStatus test
benjirewis da02e54
better table driving ?
benjirewis 2c591ad
dan comments
benjirewis d5e484f
fix client test
benjirewis 5bed7f2
Initial field on Config in place of SetInitializing
benjirewis e00ad7d
test that local package file is handled properly
benjirewis 3e6e59e
final comments
benjirewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
avoid CopyOnlyPublicFields
commit 72bada67f01ebca40fc8628efbbfb26cc73ed30d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the consequence of not having this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is the consequence; the robot would falsely report itself as running.