Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3749: Store data from viam in MongoDB #4118

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

npentrel
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Mar 21, 2025
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 331c6a5
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67e13cec84153f0008830fe3
😎 Deploy Preview https://deploy-preview-4118--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@npentrel
Copy link
Collaborator Author

@jdamon96 do you mind reviewing these changes? I'm wondering: is there a way to only capture to the configured MongoDB and disable data sync outside of that?

There was a question about this from a user.

@jdamon96
Copy link

Changes LGTM. Good clarification that the feature works regardless of whether the Mongo collection is on the local network or not.

Re: is there a way to only capture to the configured MongoDB and disable data sync outside of that?

  • because this was built as a feature of data capture and not data sync, I believe the answer to this question is yes: the user can only capture to the configured MongoDB collection by enabling this feature while disabling data sync.
  • it may be worth noting that at scoping stage, the fact this feature is coupled with data capture rather than data sync was viewed as a shortcoming and this implementation (adding this functionality to the data capture path vs data sync path) was chosen for its speedier implementation.

@jdamon96
Copy link

^ ran the above answer by Nick Sanford, he confirmed it's correct and added the clarification that in the case where the user has a direct to mongo URI provided and data sync turned off, the data will still be captured to disk (in addition to being captured to mongo)

@npentrel
Copy link
Collaborator Author

^ ran the above answer by Nick Sanford, he confirmed it's correct and added the clarification that in the case where the user has a direct to mongo URI provided and data sync turned off, the data will still be captured to disk (in addition to being captured to mongo)

quite cool, I'll make the changes later

@npentrel
Copy link
Collaborator Author

Ok @jdamon96 let me know if these updates seem good to you: 331c6a5

@npentrel npentrel requested a review from nicksanford March 25, 2025 08:48
@npentrel
Copy link
Collaborator Author

Alternatively @nicksanford would you mind reviewing this for accuracy? Thanks!

Copy link
Member

@nicksanford nicksanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@npentrel
Copy link
Collaborator Author

Thanks!

@npentrel npentrel merged commit 0c865da into viamrobotics:main Mar 25, 2025
12 checks passed
@npentrel npentrel deleted the DOCS-3749 branch March 25, 2025 19:29
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants