Refactor: Move intra-cluster RR graph code into dedicated files #3281
Conversation
github-actions
bot
added
VPR
soheilshahrouz
changed the title
| /* Connection not at end of the CHANX segment. */ | ||
| x1 = draw_coords->tile_x[chany_x] + draw_coords->get_tile_width(); | ||
| if (rr_graph.node_direction(chanx_node) != Direction::BIDIR && (SwitchType)switch_type != SwitchType::SHORT) { | ||
| if (rr_graph.node_direction(chanx_node) != Direction::BIDIR && (e_switch_type)switch_type != e_switch_type::SHORT) { |
There was a problem hiding this comment.
If it’s an easy change, I’d suggest updating the function’s parameter type from short to e_switch_type to avoid casting here.
There was a problem hiding this comment.
A few lines below, switch_type is passed to draw_rr_switch() as an RRSwitchId. I think switch_type is actually a switch id that should be used to retreive a t_rr_switch_inf. Could you please read the code and see if my understanding is correct? If so, casting it to e_switch_type is a mistake.
There was a problem hiding this comment.
This code does look funny. Do we have a special switch index that means short? We seem to be using the same variable as a switch index and a switch type ... is this a bug? It might not cause fatal problems, as it just stops some drawing code, but it seems suspicious.
| /* Connection not at end of the CHANX segment. */ | ||
| x1 = draw_coords->tile_x[chany_x] + draw_coords->get_tile_width(); | ||
| if (rr_graph.node_direction(chanx_node) != Direction::BIDIR && (SwitchType)switch_type != SwitchType::SHORT) { | ||
| if (rr_graph.node_direction(chanx_node) != Direction::BIDIR && (e_switch_type)switch_type != e_switch_type::SHORT) { |
There was a problem hiding this comment.
This code does look funny. Do we have a special switch index that means short? We seem to be using the same variable as a switch index and a switch type ... is this a bug? It might not cause fatal problems, as it just stops some drawing code, but it seems suspicious.
…ing_comments Address remaining comments from #3281
4 participants
Moves all functions that create nodes and edges for intra-cluster routing resources to separate files.