Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 19, 2025

Summary

Adds serialization support for ChatMessageTrigger workflows, including:

  • The CHAT_MESSAGE trigger type in WorkflowTriggerType enum
  • Attribute serialization with JSON fallback for complex union types that can't be mapped to primitive Vellum variable types
  • exec_config.output serialization for ChatMessageTrigger configs

Updates since last revision

  • Rebased on main
  • Reverted changes to expressions.py and test_attributes_serialization.py per reviewer request

Review & Testing Checklist for Human

  • Verify the JSON fallback in get_attribute_type() is appropriate for all attribute types that may appear in ChatMessageTrigger
  • Confirm _serialize_chat_message_trigger_exec_config correctly handles cases where Config.output is None
  • Test serialization with a real ChatMessageTrigger workflow to ensure the output format matches backend expectations

Notes

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vincent0426 vincent0426 marked this pull request as ready for review December 19, 2025 19:16
chatgpt-codex-connector[bot]

This comment was marked as resolved.

@vincent0426
Copy link
Contributor

@codex review

@vellum-ai vellum-ai deleted a comment from chatgpt-codex-connector bot Dec 22, 2025
chatgpt-codex-connector[bot]

This comment was marked as resolved.

@vincent0426
Copy link
Contributor

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1766166263-chat-message-trigger-serialization branch from 7472fd7 to c6eac80 Compare December 23, 2025 21:16
@devin-ai-integration
Copy link
Contributor Author

Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it.

2 similar comments
@devin-ai-integration
Copy link
Contributor Author

Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it.

@devin-ai-integration
Copy link
Contributor Author

Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it.

@vincent0426
Copy link
Contributor

@codex review

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@vincent0426 vincent0426 merged commit 12ef1da into main Dec 23, 2025
9 checks passed
@vincent0426 vincent0426 deleted the devin/1766166263-chat-message-trigger-serialization branch December 23, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants