Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 22, 2025

Adds TypeScript codegen support for ChatMessageTrigger with exec_config.output, enabling workflows with chat message triggers to be properly code-generated when pulled from the Vellum API. This is a companion to PR #3433 which added Python serialization support.

Key changes:

  • Added CHAT_MESSAGE to WorkflowTriggerType enum and ChatMessageTrigger interface
  • Added ChatMessageTriggerSerializer to deserialize CHAT_MESSAGE triggers from the API
  • Added ChatMessageTrigger generator that creates a subclass with Config.output when exec_config.output is present
  • Added ChatMessageTriggerContext so the workflow graph uses the generated subclass
  • Updated getTriggerClassInfo to return the generated subclass path for CHAT_MESSAGE triggers

The generated code creates a trigger subclass like:

class ChatMessage(ChatMessageTrigger):
    class Config(ChatMessageTrigger.Config):
        output = LazyReference(lambda: SomeNode.Outputs.result)

Review & Testing Checklist for Human

  • Verify the snapshot test output shows correct generated code for NODE_OUTPUT descriptor type
  • Test with a ChatMessageTrigger that has exec_config.output set to a non-NODE_OUTPUT type (e.g., CONSTANT_VALUE, WORKFLOW_INPUT) and verify the generated Config.output is correct
  • Test end-to-end: Pull a workflow with a ChatMessageTrigger from Vellum and verify the generated code works at runtime

Notes

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1766434179-chat-message-trigger-codegen branch 2 times, most recently from baf67c8 to 88ae421 Compare December 22, 2025 21:04
@vincent0426 vincent0426 marked this pull request as ready for review December 22, 2025 21:07
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1766434179-chat-message-trigger-codegen branch from dd0cbd8 to 892b352 Compare December 22, 2025 23:23
@vellum-ai vellum-ai deleted a comment from chatgpt-codex-connector bot Dec 22, 2025
@vincent0426
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vincent0426
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vincent0426
Copy link
Contributor

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vincent0426
Copy link
Contributor

@codex review

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants