-
Notifications
You must be signed in to change notification settings - Fork 18
Add codegen support for ChatMessageTrigger #3442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add codegen support for ChatMessageTrigger #3442
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
baf67c8 to
88ae421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
dd0cbd8 to
892b352
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nerate triggers without exec_config Co-Authored-By: [email protected] <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…nt node Co-Authored-By: [email protected] <[email protected]>
…rigger test Co-Authored-By: [email protected] <[email protected]>
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Adds TypeScript codegen support for
ChatMessageTriggerwithexec_config.output, enabling workflows with chat message triggers to be properly code-generated when pulled from the Vellum API. This is a companion to PR #3433 which added Python serialization support.Key changes:
CHAT_MESSAGEtoWorkflowTriggerTypeenum andChatMessageTriggerinterfaceChatMessageTriggerSerializerto deserialize CHAT_MESSAGE triggers from the APIChatMessageTriggergenerator that creates a subclass withConfig.outputwhenexec_config.outputis presentChatMessageTriggerContextso the workflow graph uses the generated subclassgetTriggerClassInfoto return the generated subclass path for CHAT_MESSAGE triggersThe generated code creates a trigger subclass like:
Review & Testing Checklist for Human
exec_config.outputset to a non-NODE_OUTPUT type (e.g., CONSTANT_VALUE, WORKFLOW_INPUT) and verify the generated Config.output is correctNotes