feat: optimize ID-driven selections #7933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvind
force-pushed
the
as/optimizedSelectionIDs
branch
2 times, most recently
from
b54ecd1 to
28a2e93
Compare
Stores for ID-driven selections use a flattened structure,
with tuples in the form of {unit, _vgsid_} sorted by _vgsid_.
And inclusion testing now occurs via a new Vega expression function
that binary searches through the store to determine a hit.
arvind
force-pushed
the
as/optimizedSelectionIDs
branch
from
c1edade to
5a6ca2d
Compare
arvind
force-pushed
the
as/optimizedSelectionIDs
branch
from
16da17a to
9551dc4
Compare
domoritz
approved these changes
Apr 7, 2022
That's a good idea but I don't think Vega has support for Sets/OrderedSets? I might've missed something though. But, in the event I haven't, I think it's a good idea for us to consider in the future or if/when we move selections down to the Vega level. |
|
Vega itself could definitely use Sets but they cannot be serialized as JSON. The solution for that is usually to represent a set as an object with values |
|
🚀 PR was released in |
Merged
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Co-authored-by: GitHub Actions Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With geo-interval (#6953) and lasso (#7932) selections on the horizon, there are going to be not only many more ID-driven selections than before, but these selections are likely going to capture many more IDs than before. As a result, this PR cherry picks selection ID-based optimizations from #6953 and improves on them in a more cross-cutting fashion.
In particular, stores for ID-driven selections use a flattened structure with tuples in the form of
{unit, _vgsid_}sorted by_vgsid_. And inclusion testing now occurs via a new Vega expression function that binary searches through the store to determine a hit.This PR relies on updates introduced in vega/vega#3397 (so runtime tests may not pass until that PR is merged and released).
📦 Published PR as canary version:
5.2.1--canary.7933.9a516dd.0✨ Test out this PR locally via:
Version
Published prerelease version:
v5.3.0-next.2Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Alicia Schep (@AliciaSchep)
❤️ James Scott-Brown (@jamesscottbrown)
❤️ Cameron Yick (@hydrosquall)
❤️ Paul Rosenzweig (@paulrosenzweig)
❤️ Jon Mease (@jonmmease)
❤️ Sid Kapur (@sid-kap)
❤️ Robin Linacre (@RobinL)
❤️ Hao Chen (@ObservedObserver)
🚀 Enhancement
🐛 Bug Fix
nextAuthors: 13