Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log correct property name #8140

Merged
merged 1 commit into from
May 4, 2022
Merged

fix: log correct property name #8140

merged 1 commit into from
May 4, 2022

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented May 2, 2022 •
edited by github-actions bot
Loading

fixes #8137

📦 Published PR as canary version: 5.2.1--canary.8140.8f29ddb.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Version

Published prerelease version: v5.3.0-next.3

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ James Scott-Brown (@jamesscottbrown)

❤️ Alicia Schep (@AliciaSchep)

❤️ Cameron Yick (@hydrosquall)

❤️ Paul Rosenzweig (@paulrosenzweig)

❤️ Jon Mease (@jonmmease)

❤️ Sid Kapur (@sid-kap)

❤️ Robin Linacre (@RobinL)

❤️ Hao Chen (@ObservedObserver)

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to next

Authors: 13

@domoritz domoritz requested a review from hydrosquall May 2, 2022 22:25
@domoritz
Copy link
Member Author

domoritz commented May 2, 2022

I couldn't test it yet. Can you @hydrosquall?

@hydrosquall
Copy link
Member

Thanks for the quick turnaround. I tried testing this remotely, but ran into a probably unrelated caching error on the Codesandbox side. Will try this again with fresh eyes (and hopefully a flushed cache) tomorrow.

https://codesandbox.io/s/strange-cookies-9kj741?file=/src/index.js

hydrosquall
hydrosquall approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@hydrosquall hydrosquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a minimal vega example codepen using the canary build, screencap provided below. It's unclear what the codesandbox problem was. In any case, "scheme" is the intended output property, so I think we can say the fix works as expected.

image

@domoritz domoritz merged commit 7787ee2 into next May 4, 2022
@domoritz domoritz deleted the dom/log branch May 4, 2022 03:02
@github-actions
Copy link

github-actions bot commented May 4, 2022

🚀 PR was released in v5.3.0-next.3 🚀

@github-actions github-actions bot mentioned this pull request Jun 21, 2022
Merged
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@domoritz @BradyJ27
fix: log correct property name (vega#8140)
c812181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydrosquall hydrosquall hydrosquall approved these changes

Assignees
No one assigned
Labels
prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Schema validator logs incorrect property name
2 participants
@domoritz @hydrosquall