Sign-up Page Functionality #202

kevin-pierce · 2023-11-16T03:34:53Z

Notion task link

Signup Page Functionality

Implementation description

Added two exceptions ; UserNotInvitedException and EmailAlreadyInUseException with corresponding error messages
Added 3 error states for email (invalid email, user not invited, email already in use)
Cleaned up dead code (unused Signup.tsx file)
Restyled Signup.tsx form to use Chakra built-in components

Steps to test

Invalid email

Attempt registration flow with invalid email (for example, testatshouldnotwork.com)
Verify that we see an "Invalid email" error appear below the email entry field
Verify that when we FIRST enter an invalid email, that we DO NOT see the error appear ; we should only see this type of error appear AFTER we have clicked the signup button

User Not Invited

Attempt to register a user with an email that has not been invited (doesn't exist in your database)
Verify that we see an "Email not invited" error appear below the email entry field

Email Already in Use

Attempt to register a user with an email already associated with an Active account
Verify that we see an "Email already in use" error appear below the email entry field

General

Verify that the sign up button remains disabled when any of the fields are blank
Verify that the sign up button remains disabled when an invalid email is present
Verify that successful registration flow operates as normal

What should reviewers focus on?

Checklist

My PR name is descriptive and in imperative tense
My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
I have run the appropriate linter(s)
I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
If I have made API changes, I have updated the REST API Docs
IF I have made changes to the db/models, I have updated the Data Models Page
I have documented this PR in the Production Release Page
I have updated other Docs as needed

github-actions · 2023-11-16T03:36:56Z

Visit the preview URL for this PR (updated for commit fb2dcf3):

https://blueprintsupportivehousing--pr202-kevin-signup-functio-hto1ingq.web.app

_{(expires Thu, 30 Nov 2023 01:34:28 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09}

…ality-new

braydonwang · 2023-11-23T01:08:57Z

backend/app/rest/auth_routes.py

@@ -3,6 +3,7 @@
    InvalidPasswordException,


Not sure if this needs to be addressed in this PR, but I was trying to sign up with an account that is "Invited" but clicking "Create Account" didn't do anything. I looked in the networks tab and found that the register endpoint failed with the error: "Invalid password string. Password must be a string at least 6 characters long." This could be unintuitive for the users since it didn't show an error box so they don't know that this password character limit exists.

Resolved ; I approached this by offloading the password verification to the frontend (by simply doing a length check to verify the password is >= 6 characters long). This check is performed both in the onClick handler for createAccount and within the handlePasswordChange function (which functions the same way as the valid email error does, in which we only check for the validity of these fields after the create account button has been clicked)

braydonwang

Besides the comment I left, everything else looks good and works well!

…ality-new

kevin-pierce · 2023-11-23T01:33:43Z

frontend/src/components/forms/Signup.tsx

-            JSON.stringify(authUser),
-          );
-          setAuthenticatedUser(authUser);
+    if (isInvited !== "Not Invited") {


The above check would trigger as long as some string was being returned here (which this function always did, even in the error case) hence we just changed the logic around

Could you explain what you mean by this? Do you mean that it would show not invited even if an invalid string was passed in?

Basically, before the condition was simply if (isInvited). However, the function call was returning (even in the error case) the string Not Invited. This meant that, even when we were supposed to be erroring out, we were interpreting the API call as successful since if (isInvited) would be true if the string was not empty

kevin-pierce · 2023-11-23T01:34:22Z

frontend/src/helper/authError.ts

+export const getAuthErrMessage = (axiosErrRes: AxiosError["response"], flow: AuthFlow): string => {
+  if (axiosErrRes && axiosErrRes.data && axiosErrRes.data.error) {
+    return axiosErrRes.data.error;
+  }
+  return `Error ${flow === 'LOGIN' ? "logging in" : "signing up"}. Please try again later.`;
+}


Takes in the auth flow (either 'LOGIN' or 'SIGNUP') from which we're accessing this method, as to consolidate the two functiosn we had before into one

kevin-pierce · 2023-11-23T01:38:20Z

frontend/src/components/forms/Login.tsx

-const isLoginErrorResponse = (
-  res: AuthTokenResponse | ErrorResponse,
-): res is ErrorResponse => {
-  return res !== null && "errCode" in res;
-};
-


Added a more comprehensive version of this function isAuthErrorResponse

connor-bechthold

muy bien

danielk1345

Looks good, and it works as expected. Only thing that I kind of struggled to understand was one of your comments

Copied over changes, nuked old Signup page

42a9f9b

kevin-pierce added 3 commits November 18, 2023 22:03

Not invited error message

4e81496

Email already in use error

6f174a0

Finalized fixes

bf28a14

kevin-pierce requested a review from connor-bechthold November 19, 2023 19:23

kevin-pierce marked this pull request as ready for review November 19, 2023 19:23

kevin-pierce added 2 commits November 19, 2023 14:31

Merge remote-tracking branch 'origin/main' into kevin-signup-function…

87bea47

…ality-new

Now displays invlaid email error FIRST

ae7c384

connor-bechthold mentioned this pull request Nov 22, 2023

Overflow gets cancelled on login | BUG #184

Merged

8 tasks

danielk1345 self-requested a review November 23, 2023 00:31

braydonwang reviewed Nov 23, 2023

View reviewed changes

Combined auth error message generator, removed redundant type

2046276

braydonwang approved these changes Nov 23, 2023

View reviewed changes

kevin-pierce added 2 commits November 22, 2023 20:26

Fixed password issue

c16dbcf

Merge remote-tracking branch 'origin/main' into kevin-signup-function…

fb2dcf3

…ality-new

kevin-pierce commented Nov 23, 2023

View reviewed changes

connor-bechthold approved these changes Nov 23, 2023

View reviewed changes

danielk1345 approved these changes Nov 23, 2023

View reviewed changes

kevin-pierce merged commit e123bf5 into main Nov 23, 2023

kevin-pierce deleted the kevin-signup-functionality-new branch November 23, 2023 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign-up Page Functionality #202

Sign-up Page Functionality #202

kevin-pierce commented Nov 16, 2023 •

edited

Loading

github-actions bot commented Nov 16, 2023 •

edited

Loading

braydonwang Nov 23, 2023

kevin-pierce Nov 23, 2023

braydonwang left a comment

kevin-pierce Nov 23, 2023

danielk1345 Nov 23, 2023

kevin-pierce Nov 23, 2023

kevin-pierce Nov 23, 2023

kevin-pierce Nov 23, 2023

connor-bechthold left a comment

danielk1345 left a comment

Sign-up Page Functionality #202

Sign-up Page Functionality #202

Conversation

kevin-pierce commented Nov 16, 2023 • edited Loading

Notion task link

Implementation description

Steps to test

Invalid email

User Not Invited

Email Already in Use

General

What should reviewers focus on?

Checklist

github-actions bot commented Nov 16, 2023 • edited Loading

braydonwang Nov 23, 2023

Choose a reason for hiding this comment

kevin-pierce Nov 23, 2023

Choose a reason for hiding this comment

braydonwang left a comment

Choose a reason for hiding this comment

kevin-pierce Nov 23, 2023

Choose a reason for hiding this comment

danielk1345 Nov 23, 2023

Choose a reason for hiding this comment

kevin-pierce Nov 23, 2023

Choose a reason for hiding this comment

kevin-pierce Nov 23, 2023

Choose a reason for hiding this comment

kevin-pierce Nov 23, 2023

Choose a reason for hiding this comment

connor-bechthold left a comment

Choose a reason for hiding this comment

danielk1345 left a comment

Choose a reason for hiding this comment

kevin-pierce commented Nov 16, 2023 •

edited

Loading

github-actions bot commented Nov 16, 2023 •

edited

Loading