Overflow gets cancelled on login | BUG

[achandrabalan]

Implementation description

• I've had this weird bug when I logout and log back in that basically freezes the screen and blocks scrolling on the actual page and only allows it on the table. I've been able to get past this with refreshing the page but that is not very intuitive for the user.

Steps to test

1. See if you can reproduce the bug on your end, press log out and then sign back in. Does the scroll lock?
2. If so, does this fix it for you?

What should reviewers focus on?

• I think this fixes it on my side not sure if it's a universal fix tho
• Also are there any risks to setting this here? I'm not too sure how it affects the rest of the app.

Checklist

• My PR name is descriptive and in imperative tense
• My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
• I have run the appropriate linter(s)
• I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
• If I have made API changes, I have updated the REST API Docs
• IF I have made changes to the db/models, I have updated the Data Models Page
• I have documented this PR in the Production Release Page
• I have updated other Docs as needed

[github-actions]

Visit the preview URL for this PR (updated for commit 79d6559):

https://blueprintsupportivehousing--pr184-aathi-testing-c9ksqtqg.web.app

_{(expires Sun, 03 Dec 2023 20:38:35 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09}

[owen-sellner]

Great job fixing the bug! I found an issue with horizontal overflow but the solution should be quick to implement.

[owen-sellner]

I noticed the same issue as before in Signup.tsx but after that I think this is ready.

[connor-bechthold]

So I noticed that the messages below the buttons for both the Signup and Login page are different - I suggested changes on the Signup Page that fix this that utilize Flexbox and removes the use of margin and padding (which could produce unexpected results on different screen sizes)

To keep things consistent the same changes can also be made on the Login page and then both forms should look identical styling wise and this should be good to go! Let me know if you have any questions/confusions with the suggestions at all.

[connor-bechthold]

LOOKS GREAT I left like a million comments on this one so thanks for addressing everything 🙏

This should be good to merge once #202 is merged (just because it adds error messages on this page that will cause conflicts, but should be easier to address in this PR)

[owen-sellner]

LGTM!!!!