You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Themes: call store themes SteamOS-like, not Steam Deck - #2418
The theme manager called themes from the store tab "Steam Deck" themes. The app adapts those themes to its own screens, so the result is not the same as on a Steam Deck and the name promised more than it gives. The tab is now "SteamOS-like", and the line that says which themes cannot be shared uses the same words. All 16 languages are updated. String keys are unchanged.
Recording
Not recorded: two strings.
Type of Change
Bug fix
Performance / stability improvement
Compatibility improvements
Other (requires prior approval)
Checklist
If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
I have attached a recording of the change.
I have read and agree to the contribution guidelines in CONTRIBUTING.md.
Summary by cubic
Renames store themes in the theme manager from "Steam Deck" to "SteamOS-like". These themes are adapted to the app's own screens, so the old name promised a result that matches an actual Steam Deck when it doesn't.
Updates the store tab label and the sharing restriction message in all 16 supported languages.
String keys are unchanged, so no code references need updating.
Written for commit 95cd5a8. Summary will update on new commits.
Summary by CodeRabbit
Updates
Theme labels and sharing restriction messages now describe this category as “SteamOS-style” rather than “Steam Deck” across supported languages.
No actionable comments were generated in the recent review.
Walkthrough
The theme tab label and sharing restriction message now describe the category as SteamOS-style instead of Steam Deck in the base resources and 16 translations.
Changes: Theme terminology
Layer / File(s)
Summary
Localized theme labels and sharing messages app/src/main/res/values/strings.xml, app/src/main/res/values-{da,de,es,fr,it,ja,ko,pl,pt-rBR,ro,ru,tr,uk,zh-rCN,zh-rTW}/strings.xml
The theme tab label and sharing restriction message use SteamOS-style wording instead of Steam Deck wording across the listed resources.
This updates the theme tab label and the sharing restriction message to say "SteamOS-like" instead of "Steam Deck". It only changes displayed text, and the risk of merging is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: the store themes label changes from Steam Deck to SteamOS-like. The description and the file summaries confirm this, since all 16 locale files change the same theme la…
Description check
The description states what changed and why: store themes are adapted to the app's own screens, so the Steam Deck name overpromised. It covers the tab label, the sharing message, the 16 updated langua…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the store themes label changes from Steam Deck to SteamOS-like. The description and the file summaries confirm this, since all 16 locale files change the same theme label and sharing message. The title is specific and accurate.
Full details: Description check
Explanation
The description states what changed and why: store themes are adapted to the app's own screens, so the Steam Deck name overpromised. It covers the tab label, the sharing message, the 16 updated languages, and the unchanged string keys. It marks the change as Other (requires prior approval) and checks the required boxes. The recording is missing, and the description says so: two strings, not recorded. The checklist item for the recording stays unchecked, so the author should either attach a recording or justify skipping it, since the template asks for one.
Resolution
Consider attaching a short recording or screenshot of the renamed theme tab and sharing message, or explain why a recording is not needed. The recording checklist item is still unchecked.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 0fac6e7c-fd44-46f3-ab30-98c6dd80c7bd
Commits
Reviewing files that changed from the base of the PR and between 4f75807 and 95cd5a8.
Files selected for processing: 16
app/src/main/res/values-da/strings.xml
app/src/main/res/values-de/strings.xml
app/src/main/res/values-es/strings.xml
app/src/main/res/values-fr/strings.xml
app/src/main/res/values-it/strings.xml
app/src/main/res/values-ja/strings.xml
app/src/main/res/values-ko/strings.xml
app/src/main/res/values-pl/strings.xml
app/src/main/res/values-pt-rBR/strings.xml
app/src/main/res/values-ro/strings.xml
app/src/main/res/values-ru/strings.xml
app/src/main/res/values-tr/strings.xml
app/src/main/res/values-uk/strings.xml
app/src/main/res/values-zh-rCN/strings.xml
app/src/main/res/values-zh-rTW/strings.xml
app/src/main/res/values/strings.xml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The theme manager called themes from the store tab "Steam Deck" themes. The app adapts those themes to its own screens, so the result is not the same as on a Steam Deck and the name promised more than it gives. The tab is now "SteamOS-like", and the line that says which themes cannot be shared uses the same words. All 16 languages are updated. String keys are unchanged.
Recording
Not recorded: two strings.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Renames store themes in the theme manager from "Steam Deck" to "SteamOS-like". These themes are adapted to the app's own screens, so the old name promised a result that matches an actual Steam Deck when it doesn't.
Written for commit 95cd5a8. Summary will update on new commits.
Summary by CodeRabbit