Skip to content

applyFileSystemEdits called from a REPL now operates directly on disk #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 24, 2025
Merged

applyFileSystemEdits called from a REPL now operates directly on disk #2495

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89a27cc
applyFileSystemEdits called from a REPL now operates directly on disk…
rodinaarssen Oct 21, 2025
6cbaace
Improved file system edit application after review comments by @DavyL…
rodinaarssen Oct 22, 2025
1547ecf
Removed unnecessary parentheses
rodinaarssen Oct 22, 2025
d2be4d5
Only requesting character encoding once per edit
rodinaarssen Oct 23, 2025
e1279a6
Using streaming concat for edits
rodinaarssen Oct 23, 2025
a4a8bed
Using streaming writer to write edited files
rodinaarssen Oct 24, 2025
883b372
Dropped intermediate stringwriters
rodinaarssen Oct 24, 2025
69e2b97
Removed unused import
rodinaarssen Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 56 additions & 2 deletions src/org/rascalmpl/library/util/IDEServicesLibrary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@

import org.rascalmpl.exceptions.RuntimeExceptionFactory;
import org.rascalmpl.ideservices.IDEServices;
import org.rascalmpl.library.Prelude;
import org.rascalmpl.repl.http.REPLContentServer;
import org.rascalmpl.repl.http.REPLContentServerManager;
import org.rascalmpl.uri.URIResolverRegistry;
import org.rascalmpl.uri.URIUtil;
import org.rascalmpl.values.IRascalValueFactory;
import org.rascalmpl.values.functions.IFunction;
Expand Down Expand Up @@ -56,8 +58,61 @@ public void registerLanguage(IConstructor language) {
public void applyDocumentsEdits(IList edits) {
applyFileSystemEdits(edits);
}

public void applyFileSystemEdits(IList edits) {
services.applyFileSystemEdits(edits);
var registry = URIResolverRegistry.getInstance();
var vf = IRascalValueFactory.getInstance();
edits.stream().map(IConstructor.class::cast).forEach(c -> {
try {
switch (c.getName()) {
case "removed": {
var file = (ISourceLocation) c.get("file");
registry.remove(file.top(), false);
break;
}
case "created": {
var file = (ISourceLocation) c.get("file");
if (registry.exists(file)) {
registry.setLastModified(file, System.currentTimeMillis());
} else {
try (var out = registry.getCharacterWriter(file.top(), registry.detectCharset(file).name(), false)) {
out.write("");
}
}
break;
}
case "renamed": {
var from = (ISourceLocation) c.get("from");
var to = (ISourceLocation) c.get("to");
registry.rename(from.top(), to.top(), true);
break;
}
case "changed": {
var file = (ISourceLocation) c.get("file");
if (c.has("edits")) {
var textEdits = (IList) c.get("edits");
var contents = Prelude.readFile(vf, false, ((ISourceLocation) c.get("file")).top(), null, true);
for (var e : textEdits.reverse()) {
var edit = (IConstructor) e;
var range = (ISourceLocation) edit.get("range");
var prefix = contents.substring(0, range.getOffset());
var replacement = (IString) edit.get("replacement");
var postfix = contents.substring(range.getOffset() + range.getLength());
contents = prefix.concat(replacement).concat(postfix);
};
try (var writer = registry.getCharacterWriter(file.top(), registry.detectCharset(file).name(), false)) {
writer.write(contents.getValue());
}
} else {
registry.setLastModified(file, System.currentTimeMillis());
}
break;
}
}
} catch (IOException e) {
services.warning("Could not execute FileSystemChange due to " + e.getMessage(), URIUtil.rootLocation("unknown"));
}
});
}

public void showInteractiveContent(IConstructor provider, IString title, IInteger viewColumn) {
Expand Down Expand Up @@ -94,7 +149,6 @@ public void logMessage(IConstructor message) {
services.logMessage(message);
}


public void registerDiagnostics(IList messages) {
services.registerDiagnostics(messages);
}
Expand Down