-
Notifications
You must be signed in to change notification settings - Fork 81
applyFileSystemEdits called from a REPL now operates directly on disk #2495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, instead of through LSP. Closes usethesource/rascal-language-servers#844
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2495 +/- ##
=======================================
- Coverage 47% 47% -1%
+ Complexity 6626 6621 -5
=======================================
Files 783 783
Lines 64703 64741 +38
Branches 9688 9691 +3
=======================================
- Hits 30724 30711 -13
- Misses 31580 31628 +48
- Partials 2399 2402 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is nice and compact, but has some issues with surrogate pairs (and closing of streams in all cases)
applyFileSystemEditscalled from a REPL now operates directly on disk instead of through LSP.Closes usethesource/rascal-language-servers#844