Skip to content

Conversation

@rodinaarssen
Copy link
Member

applyFileSystemEdits called from a REPL now operates directly on disk instead of through LSP.

Closes usethesource/rascal-language-servers#844

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 47%. Comparing base (6cfa756) to head (69e2b97).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...org/rascalmpl/library/util/IDEServicesLibrary.java 0% 39 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2495   +/-   ##
=======================================
- Coverage       47%     47%   -1%     
+ Complexity    6626    6621    -5     
=======================================
  Files          783     783           
  Lines        64703   64741   +38     
  Branches      9688    9691    +3     
=======================================
- Hits         30724   30711   -13     
- Misses       31580   31628   +48     
- Partials      2399    2402    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is nice and compact, but has some issues with surrogate pairs (and closing of streams in all cases)

@DavyLandman DavyLandman merged commit 0469d40 into main Oct 24, 2025
6 of 7 checks passed
@rodinaarssen rodinaarssen deleted the fix-lsp-844 branch October 24, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal IO sees different file/editor contents than IDEServices::applyFileSystemEdits

2 participants