This repository was archived by the owner on May 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
ToygarAksoy-homework4 #93
Open
ttoygar
wants to merge
2
commits into
upy:main
Choose a base branch
from
ttoygar:ToygarAksoy-homework4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,17 @@ | ||
| from rest_framework import viewsets | ||
| from decimal import Decimal | ||
|
|
||
| from django.db.transaction import atomic | ||
| from rest_framework import viewsets, status, mixins | ||
| from rest_framework.decorators import action | ||
| from rest_framework.permissions import AllowAny | ||
| from rest_framework.response import Response | ||
|
|
||
| from baskets.filters import BasketItemFilter, BasketFilter | ||
| from baskets.models import BasketItem, Basket | ||
| from baskets.serializers import BasketItemSerializer, BasketSerializer, BasketItemDetailedSerializer, BasketDetailedSerializer | ||
| from baskets.serializers import BasketItemSerializer, BasketSerializer, \ | ||
| BasketItemDetailedSerializer, BasketDetailedSerializer | ||
| from core.mixins import DetailedViewSetMixin | ||
| from products.models import Product | ||
|
|
||
|
|
||
| class BasketItemViewSet(DetailedViewSetMixin, viewsets.ModelViewSet): | ||
|
|
@@ -15,12 +23,77 @@ class BasketItemViewSet(DetailedViewSetMixin, viewsets.ModelViewSet): | |
| "detailed": BasketItemDetailedSerializer, | ||
| } | ||
|
|
||
| def get_queryset(self): | ||
| queryset = super().get_queryset() | ||
| user_id = self.request.user.id | ||
| return queryset.filter(basket__customer__id=user_id) | ||
|
|
||
|
|
||
| class BasketViewSet(DetailedViewSetMixin, viewsets.ModelViewSet): | ||
| # lookup_field = 'basket' | ||
| permission_classes = () | ||
| http_method_names = ["get", "delete"] | ||
| queryset = Basket.objects.all() | ||
| serializer_class = BasketSerializer | ||
| filterset_class = BasketFilter | ||
| serializer_action_classes = { | ||
| "detailed_list": BasketDetailedSerializer, | ||
| "detailed": BasketDetailedSerializer, | ||
| "add_basket_item": BasketItemSerializer, | ||
| "get_basket_items": BasketItemSerializer, | ||
| } | ||
|
|
||
| def get_queryset(self): | ||
| queryset = super().get_queryset() | ||
| user = self.request.user | ||
| return queryset.filter(customer=user) | ||
|
|
||
| @action(detail=False, methods=['get'], http_method_names=['get']) | ||
| def get_basket_items(self, request): | ||
| """ | ||
| An endpoint to show all items under the basket. | ||
| """ | ||
| user = self.request.user | ||
| basket_items_list = self.get_queryset().filter( | ||
| customer__id=user.id).first().basketitem_set.all() | ||
| serializer = self.get_serializer(basket_items_list, many=True) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. burada basketitem serializer'inin datasini donmek guzel bir fikir olmayabilir, ilgili viewset kendi modeline ait serializer'i donmesi daha iyi olacaktir. |
||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
|
|
||
| @action(detail=True, methods=['post'], http_method_names=['post']) | ||
| @atomic() | ||
| def add_basket_item(self, request, pk=None): | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tum bu methoddaki kayit islemlerini, validationlari serializer'a yaptirmak daha iyi olacaktir. |
||
| """ | ||
| Adds an item to the basket and updates stocks. | ||
| """ | ||
| pk = None | ||
| user = self.request.user | ||
|
|
||
| basket = self.get_object() | ||
| try: | ||
| product = Product.objects.get(id=request.data["product"]) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. request.data'yı serialize edip kullansak daha iyi olabilir. |
||
| quantity = int(request.data["quantity"]) | ||
| price = Decimal(request.data["price"]) | ||
| except Exception as e: | ||
| return Response({'status': 'fail'}) | ||
|
|
||
| stock = product.stock | ||
| if stock.quantity <= 0 or stock.quantity < quantity: | ||
| return Response({'status': 'fail'}) | ||
|
|
||
| item_in_basket = BasketItem.objects.filter(basket=basket, | ||
| product=product, | ||
| price=price).first() | ||
| if item_in_basket: | ||
| item_in_basket.quantity += quantity | ||
| stock.quantity -= quantity | ||
| stock.save() | ||
| item_in_basket.save() | ||
| else: | ||
| new_item = BasketItem(basket=basket, product=product, | ||
| quantity=quantity, price=price) | ||
| stock.quantity -= quantity | ||
| stock.save() | ||
| new_item.save() | ||
|
|
||
| serializer = BasketSerializer(basket) | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basketi kullaniciya sildirmek guzel bir fikir olmayabilir.