This repository was archived by the owner on May 12, 2023. It is now read-only.
ToygarAksoy-homework4 #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| basket = self.get_object() | ||
| try: | ||
| product = Product.objects.get(id=request.data["product"]) |
There was a problem hiding this comment.
request.data'yı serialize edip kullansak daha iyi olabilir.
bu çekleri serializerda yapmış oluruz.
upy
reviewed
Jan 12, 2022
| class BasketViewSet(DetailedViewSetMixin, viewsets.ModelViewSet): | ||
| # lookup_field = 'basket' | ||
| permission_classes = () | ||
| http_method_names = ["get", "delete"] |
Owner
There was a problem hiding this comment.
basketi kullaniciya sildirmek guzel bir fikir olmayabilir.
| user = self.request.user | ||
| basket_items_list = self.get_queryset().filter( | ||
| customer__id=user.id).first().basketitem_set.all() | ||
| serializer = self.get_serializer(basket_items_list, many=True) |
Owner
There was a problem hiding this comment.
burada basketitem serializer'inin datasini donmek guzel bir fikir olmayabilir, ilgili viewset kendi modeline ait serializer'i donmesi daha iyi olacaktir.
|
|
||
| @action(detail=True, methods=['post'], http_method_names=['post']) | ||
| @atomic() | ||
| def add_basket_item(self, request, pk=None): |
Owner
There was a problem hiding this comment.
tum bu methoddaki kayit islemlerini, validationlari serializer'a yaptirmak daha iyi olacaktir.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.