Refactor internal steps, headers and body creation #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private prefixHeaders(contentType: string): HeadersResponse { | ||
| const { rawHeaders, workflowHeaders, failureHeaders } = this.headers; | ||
|
|
||
| const isCall = this.stepInfo?.lazyStep.stepType === "Call"; |
There was a problem hiding this comment.
Please double check if the following conditions are equivalent in all cases:
Old version:
!step?.callUrl
New version:
this.stepInfo?.lazyStep.stepType === "Call"
this.stepInfo?.lazyStep instanceof LazyCallStep
CahidArda
commented
Mar 19, 2025
| [WORKFLOW_ID_HEADER]: this.workflowConfig.workflowRunId, | ||
| [WORKFLOW_URL_HEADER]: this.workflowConfig.workflowUrl, | ||
| [WORKFLOW_FEATURE_HEADER]: "LazyFetch,InitialBody", | ||
| [WORKFLOW_PROTOCOL_VERSION_HEADER]: WORKFLOW_PROTOCOL_VERSION, |
There was a problem hiding this comment.
send in workflowHeaders
we were getting type errors after @types/express v5.0.1 was released a week ago. Pinning the version of this package in the workflow-js and examples/express to 5.0.0 fixed the issue. But this wasn't a good solution in the long term. another solution was removing the dependency from examples/express and keeping it in workflow-js. We don't import anything from @types/express but we still need it in our dependencies.
yunusemreozdemir
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a single method for getting headers,
getHeaders. This would compute the headers for wait for event, context.call etc. It would handle flow control and retries. It would handle failure function. This made it possible to keep all header related logic in a single place but it was complicated.When it comes to request bodies, some of the logic was in getHeaders (timeoutHeaders), some of it was in auto-executor, some of it was in serve-many (invokeWorkflow).
With this PR:
qstash/submit-steps.tsto submit plan steps and result steps.