Skip to content

DX-1691: Add workflow parameter to context.call #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 21, 2025
Merged

DX-1691: Add workflow parameter to context.call #75

merged 9 commits into from
Mar 21, 2025

Conversation

CahidArda
Copy link
Collaborator

@CahidArda CahidArda commented Feb 26, 2025 •
edited
Loading

Adds workflow parameter to context.call which will call the workflow in a typesafe way

const result = await context.call("call other workflow", {
  workflow: workflowOne,
  body: 2,
});

@linear Linear
Copy link

linear bot commented Feb 26, 2025

DX-1691 workflow-js - waitForResponse parameter for invoke

CahidArda
CahidArda commented Mar 4, 2025
View reviewed changes
@CahidArda CahidArda marked this pull request as ready for review March 7, 2025 10:13
CahidArda added 2 commits March 7, 2025 13:47
@CahidArda
fix: fmt
1e82b0a
@CahidArda
fix: flaky invoke test
9d99292 
test was checking the result of context.notify in a loop, which resulted in different number of calls. fixed it by waiting for a long while and notifying once.
@CahidArda CahidArda changed the title DX-1691: Add waitForResult parameter to invoke DX-1691: Add workflow parameter to context.call Mar 12, 2025
yunusemreozdemir
yunusemreozdemir reviewed Mar 19, 2025
View reviewed changes
@yunusemreozdemir
Copy link
Contributor

Can you provide some information on why the tests are failing?

@CahidArda
Copy link
Collaborator Author

we are getting errors because of timeouts caused by QStash. Trying to pass them with retries.

@CahidArda CahidArda merged commit cb28b8e into main Mar 21, 2025
17 of 20 checks passed
@CahidArda CahidArda deleted the DX-1691-waitForResult-in-invoke branch March 21, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunusemreozdemir yunusemreozdemir yunusemreozdemir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CahidArda @yunusemreozdemir