[production/GFS.v17] Add zstandard restart option and update WW3 hash#3105
[production/GFS.v17] Add zstandard restart option and update WW3 hash#3105dpsarmie wants to merge 5 commits intoufs-community:production/GFS.v17from
Conversation
|
Thank you @dpsarmie ! |
|
Have we activated these zstandard_level_rst and ideflate_rst options and tested debug, mpi, threading, restart reproducibility? |
I've tested these changes with the operational config for v17 and using RTs. There are some failures with RTs that have GOCART. I will be investigating this to see what the issue could be. For all associated v17 tests, it runs fine and reproduces. These changes will not be for develop until the issue with non-v17 configurations are resolved (and if we decide that these options are needed). The option will be turned off for v17 in the workflow for now, but the leads wanted this option available to do their own end-to-end tests in the workflow to make sure that the zstandard restarts work with DA, restarts, etc. So long story short, this will still need to be tested in GW (which is why we're bringing in these changes now) but for the v17 related testing, it looks to be working and checking all the needed boxes. If it fails in GW, then the option will be turned off or even have the |
NickSzapiro-NOAA
left a comment
There was a problem hiding this comment.
Sounds good, thanks @dpsarmie . I wasn't aware GW did reproducibility tests ... are these existing tests or TBD for this feature?
|
There's GW testing of this branch that is ongoing. So I will merge this into production once I get the go ahead from the project leads. |
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
This update brings in a couple of updates:
Separate Zstandard options for the output and restarts: The project asked for the capability to set the zstandard compression options to the output and the restart separately. Currently, one option is applied to both. The changes in UFSATM allow for this option to now be controlled by the
zstandard_level_rstandideflate_rstoptions in themodel_configurefile. This was tested but will not be added to develop at this time.Update the MOM6 namelist with the WRTIE_GEOM variable:
Changes made in add GUST_CONST as a variable #3056 for WRITE_GEOM will be brought into production.
Update the WW3 hash with the production branch:
The hash for WW3 to point to the newly made
production/GFS.v17branch. This update also brings in EE2 changes that are already in develop (Sync WW3 develop to dev/ufs-weather-model #3091).Commit Message:
Priority:
Git Tracking
UFSWM:
No issues for production branch updates
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: