[dev/GFS.v17] Add new Zstd option and update UFSWM hash#4579
Draft
dpsarmie wants to merge 4 commits intoNOAA-EMC:dev/gfs.v17from
Draft
[dev/GFS.v17] Add new Zstd option and update UFSWM hash#4579dpsarmie wants to merge 4 commits intoNOAA-EMC:dev/gfs.v17from
dpsarmie wants to merge 4 commits intoNOAA-EMC:dev/gfs.v17from
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -45,6 +45,8 @@ FV3_model_configure() { | |||
| local OUTPUT_FILE="'${OUTPUT_FILETYPE_ATM}' '${OUTPUT_FILETYPE_SFC}'" | |||
| local ZSTANDARD_LEVEL=${zstandard_level:-0} | |||
| local IDEFLATE=${ideflate:-0} # netCDF zlib lossless compression (0-9); 0: no compression | |||
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| local IDEFLATE=${ideflate:-0} # netCDF zlib lossless compression (0-9); 0: no compression | |
| local IDEFLATE=${ideflate:-0} # netCDF zlib lossless compression (0-9); 0: no compression |
Comment on lines
+49
to
50
| local IDEFLATE_RST=${ideflate_rst:-0} # Restart files: netCDF zlib lossless compression (0-9); 0: none | ||
| local QUANTIZE_NSD=${quantize_nsd:-0} # netCDF compression |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| local IDEFLATE_RST=${ideflate_rst:-0} # Restart files: netCDF zlib lossless compression (0-9); 0: none | |
| local QUANTIZE_NSD=${quantize_nsd:-0} # netCDF compression | |
| local IDEFLATE_RST=${ideflate_rst:-0} # Restart files: netCDF zlib lossless compression (0-9); 0: none | |
| local QUANTIZE_NSD=${quantize_nsd:-0} # netCDF compression |
dev/parm/config/gfs/config.ufs
Outdated
Contributor
There was a problem hiding this comment.
I think this line needs zstandard_level_rst and
ideflate_rst added to it.
Contributor
Author
There was a problem hiding this comment.
You're right, added those variables.
Contributor
|
CI is running for -G on gaea and wcoss2. |
DavidHuber-NOAA
added
the
GFS Change
Contributor
|
Cactus CI: The failures in C96_atm3DVar_extended_t4579 were in 2021122118/gfs_atmos_prod_f219-f240.log.0:/lfs/h2/emc/couple/noscrub/jessica.meixner/gwpr4579/global-workflow/scripts/exglobal_atmos_products.sh: line 153: pgb2bfile_f231_0p50.idx: Disk quota exceeded 2021122118/gfs_gempak_f240-f252.log.0 : My guess is that there were disk issues that caused these jobs to run over time, or just simply fail. |
Contributor
|
Gaea is still running: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO DO:
UFSWM hash points to my local fork. Hash will be updated once the UFWM is merged.
Description
These changes are for the dev/GFS.v17 branch of the workflow. This PR brings in three main changes from the UFSWM production branch.
Changes made in add GUST_CONST as a variable for WRITE_GEOM will be brought into production.
The hash for WW3 to point to the newly made production/GFS.v17 branch. This update also brings in EE2 changes that are already in develop (Sync WW3 develop to dev/ufs-weather-model ufs-community/ufs-weather-model#3091
These USFWM changes required changes to the GW variable definition files and those changes are also a part of this PR.
Zstandard compression options will be left as default for now. To enable them,
zstandard_level_rstinconfig.ufsshould be set to 5.Type of change
Change characteristics
How has this been tested?
This has not been tested in GW. I have run RTs and operational v17 configurations with the UFSWM hash on WCOSS2.
Checklist