Skip to content

Upgrade WM to spack-stack 2.1.x #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gspetro-NOAA wants to merge 10 commits into
base: ufs/dev
Choose a base branch
from
+9 −3
Draft

Upgrade WM to spack-stack 2.1.x #368

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a89b864
update CMakeLists.txt sp -> ip
gspetro-NOAA Apr 2, 2026
414e910
pick up splat in sfcsub
gspetro-NOAA Apr 2, 2026
33f5af1
improve ccpp backwards compatibility for ip/sp
gspetro-NOAA Apr 6, 2026
8ec20d7
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
gspetro-NOAA Apr 16, 2026
c9ee543
sync w/ufs/dev
gspetro-NOAA Apr 16, 2026
7a7d6d2
fix syntax error
gspetro-NOAA Apr 17, 2026
7148dfa
fix syntax error, pick up splat
gspetro-NOAA Apr 17, 2026
6464d07
Merge branch 'feature/ss2.x' of github.com:gspetro-NOAA/ccpp-physics …
gspetro-NOAA Apr 17, 2026
673b3a2
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
gspetro-NOAA Apr 25, 2026
a106523
Merge branch 'ufs-community:ufs/dev' into feature/ss2.x
gspetro-NOAA May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ target_include_directories(ccpp_physics PUBLIC

target_link_libraries(ccpp_physics PRIVATE MPI::MPI_Fortran)
target_link_libraries(ccpp_physics PUBLIC w3emc::w3emc_d
sp::sp_d
ip::ip_d
Copy link
Copy Markdown

@climbfuji climbfuji Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't @grantfirl or someone from DTC make a similar (albeit more flexible) change recently in NCAR ccpp-physics main?

Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was just testing a combined PR syncing NCAR/main (which already contains the IP changes) back to this branch. See #369 for the draft PR.

Copy link
Copy Markdown
Author

@gspetro-NOAA gspetro-NOAA Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I will take a look and incorporate here. This is mostly a placeholder PR at the moment; it may be that this PR will get closed out if others take care of the work. I'm trying to replicate Rick and Ratko's WM RT results and then go from there to see what else needs to be done. I was just getting the potential sub-PRs & issues open for visibility/tracking.

NetCDF::NetCDF_Fortran
)
#add FMS for FV3 only
Expand Down
2 changes: 2 additions & 0 deletions physics/Interstitials/UFS_SCM_NEPTUNE/sfcsub.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ subroutine sfccycle(lugb,len,lsoil,sig1t,deltsfc &
&, min_ice &
&, ialb,isot,ivegsrc,tile_num_ch,i_index,j_index)
use machine , only : kind_io8,kind_io4
! pick up splat()
use sp_mod
implicit none
character(len=*), intent(in) :: tile_num_ch
integer, intent(in) :: i_index(len), j_index(len), &
Expand Down
Loading