Upgrade WM to spack-stack 2.1.x#368
Upgrade WM to spack-stack 2.1.x#368gspetro-NOAA wants to merge 10 commits intoufs-community:ufs/devfrom
Conversation
| target_link_libraries(ccpp_physics PRIVATE MPI::MPI_Fortran) | ||
| target_link_libraries(ccpp_physics PUBLIC w3emc::w3emc_d | ||
| sp::sp_d | ||
| ip::ip_d |
There was a problem hiding this comment.
Didn't @grantfirl or someone from DTC make a similar (albeit more flexible) change recently in NCAR ccpp-physics main?
There was a problem hiding this comment.
Yes, I was just testing a combined PR syncing NCAR/main (which already contains the IP changes) back to this branch. See #369 for the draft PR.
There was a problem hiding this comment.
Awesome, thanks! I will take a look and incorporate here. This is mostly a placeholder PR at the moment; it may be that this PR will get closed out if others take care of the work. I'm trying to replicate Rick and Ratko's WM RT results and then go from there to see what else needs to be done. I was just getting the potential sub-PRs & issues open for visibility/tracking.
… into feature/ss2.x
…into feature/ss2.x
… into feature/ss2.x
gspetro-NOAA
changed the title
5 participants
Description of Changes:
Contains ccpp/physics code changes from EPIC that are required to upgrade the WM to spack-stack v2.1.0
Tests Conducted:
In progress.
We will be testing the RTs and troubleshooting failing tests with developers. This may lead to separate PRs from those developers to ensure that their tests work with the new stack, esp. LLVM compilers.
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
There are related atmos_cubed_sphere and UPP PRs, but there is no dependency between those and CCPP.
Documentation:
Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? If so, brief supporting material can be provided here. Contact the CODEOWNERS if your PR requires extensive updates to the documentation. See https://github.com/NCAR/ccpp-doc for Technical Documentation or https://dtcenter.org/community-code/common-community-physics-package-ccpp/documentation for the latest Scientific Documentation.
Issue (optional):
If this PR is resolving or referencing one or more issues, in this repository or elsewhere, list them here. For example, Related to ufs-community/ufs-weather-model#3067
Contributors (optional):
@RatkoVasic-NOAA @rickgrubin-noaa