MIDRC-1292 Fix S3 proxy for Nextflow workflows against Minio - #169
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Integration Tests on Kind
|
Integration TestsTest summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
Integration Tests
|
| # which represents a string-string map". Band-aid fix: drop it | ||
| # See https://github.com/minio/minio-go/issues/2235 | ||
| headers.pop("x-amz-server-side-encryption-context", None) | ||
| # TODO: this should be fixed in the latest version of Funnel... test it |
There was a problem hiding this comment.
The funnel PR with this change is not merged yet. See -- calypr/funnel#1428
We could test it first in a kind setup and then merge it. For now, we could just update the TODO comment to reflect the same.
There was a problem hiding this comment.
Yeah i guess that's what i meant here - i don't want to priorize testing it now, but i added the note so we remember to do it later
There was a problem hiding this comment.
i can update the comment - waiting to see if you have any other comments
nss10
left a comment
nss10
left a comment
There was a problem hiding this comment.
Left some questions/comments. Will approve once answered/changes made
| uses: uc-cdis/.github/.github/workflows/integration_tests.yaml@master | ||
| with: | ||
| SERVICE_TO_TEST: gen3_workflow | ||
| TEST_REPO_BRANCH: enable-kind-nextflow |
There was a problem hiding this comment.
Are you planning to merge the TEST REPO BRANCH along with this PR?
There was a problem hiding this comment.
I would merge this PR first. There's another change in the gen3-code-vigil branch that i want to test
There was a problem hiding this comment.
Gotcha. We need to make sure this is removed before we delete the code-vigil branch.
There was a problem hiding this comment.
Oh i'm just removing it before merging! There are no breaking changes here
| SETUP_SCRIPT_1: https://raw.githubusercontent.com/uc-cdis/gen3-workflow/refs/heads/${{ github.event.pull_request.head.ref }}/.github/workflows/integration_tests_on_kind/ci_start_kind_cluster.sh | ||
| SETUP_SCRIPT_2: https://raw.githubusercontent.com/uc-cdis/gen3-workflow/refs/heads/${{ github.event.pull_request.head.ref }}/.github/workflows/integration_tests_on_kind/ci_override_config_and_start_minio.sh | ||
| SETUP_SCRIPT_3: https://raw.githubusercontent.com/uc-cdis/gen3-workflow/refs/heads/${{ github.event.pull_request.head.ref }}/.github/workflows/integration_tests_on_kind/ci_expose_kind_cluster.sh | ||
| TEST_REPO_BRANCH: enable-kind-nextflow |
2 participants
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/MIDRC-1292
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes