Add NonEmptyHotswap #4267
Open
Add NonEmptyHotswap #4267
+392
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Thanks for the PR!
Honestly, I wonder if we should deprecate the old HotSwap.
Hotswap[F, A]is justNonEmptyHotswap[F, Option[A]]. We don't need both.- The current
HotswapAPI is broken anyway, e.g. see MakeHotSwapsafe to concurrent access #3480 (comment).
@djspiewak I know you hate it, but there are so many things we could fix if we just embrace the ugly Hotswap2, Queue2, 😅
Oh, also you should retarget to series/3.6.x if you want it to make the next release (@djspiewak are we still merging new APIs into this branch?)
std/shared/src/main/scala/cats/effect/std/NonEmptyHotswap.scala
Outdated
Show resolved
Hide resolved
std/shared/src/main/scala/cats/effect/std/NonEmptyHotswap.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Arman Bilge <[email protected]>
Co-authored-by: Arman Bilge <[email protected]>
morgen-peschke
force-pushed
the
add-nonempty-version-of-hotswap
branch
from
11ca512 to
e9965a3
Compare
Also adds two methods to make `NonEmptyHotswap` a drop-in replacement for `Hotswap`
This reverts commit 8dc9fcf.
armanbilge
reviewed
Feb 7, 2025
…otspot" This reverts commit bcfb4b0.
This reverts commit 4b7ebe4.
Thanks to armanbilge for the [suggestion](typelevel#4267 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects the site docs for
Hotswapso it conforms to theHotswapAPIAddresses #4268