Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Doc for Hotswap has a broken example #4268

Open
morgen-peschke opened this issue Feb 6, 2025 · 0 comments
Open

Site Doc for Hotswap has a broken example #4268

morgen-peschke opened this issue Feb 6, 2025 · 0 comments

Comments

@morgen-peschke
Copy link

The site doc example of a rotating logger assumes an API that doesn't match the one provided by Hotswap.

The assumed API would be much easier to work with in certain cases, though would need to be less powerful than what's provided by Hotswap. I think the missing abstraction could be useful, a NonEmptyHotswap would provide similar value as NonEmptyList.

I've taken a stab at this in #4267, and it looks promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant