fix: same name of the components should add an error to the circuit json

lib/components/normal-components/Board.ts

@@ -149,6 +149,9 @@ export class Board extends Group<typeof boardProps> {
     if (this.root?.pcbDisabled) return
     if (this.getInheritedProperty("routingDisabled")) return
     const { db } = this.root!
+
+    super.doInitialPcbDesignRuleChecks()
+
     const errors = checkEachPcbTraceNonOverlapping(db.toArray())
     for (const error of errors) {
       db.pcb_trace_error.insert(error)

lib/components/primitive-components/Group/Group.ts

@@ -25,6 +25,8 @@ import { TraceHint } from "../TraceHint"
 import type { ISubcircuit } from "./ISubcircuit"
 import { getSimpleRouteJsonFromCircuitJson } from "lib/utils/public-exports"
 import type { GenericLocalAutorouter } from "lib/utils/autorouting/GenericLocalAutorouter"
+import { checkEachPcbTraceNonOverlapping } from "@tscircuit/checks"
+import type { PrimitiveComponent } from "lib/components/base-components/PrimitiveComponent"
 
 export class Group<Props extends z.ZodType<any, any, any> = typeof groupProps>
   extends NormalComponent<Props>
@@ -714,4 +716,41 @@ export class Group<Props extends z.ZodType<any, any, any> = typeof groupProps>
     const autorouter = this._getAutorouterConfig()
     return autorouter.groupMode === "sequential-trace"
   }
+
+  doInitialPcbDesignRuleChecks() {
+    if (this.root?.pcbDisabled) return
+    if (this.getInheritedProperty("routingDisabled")) return
+    const { db } = this.root!
+
+    if (this.isSubcircuit) {
+      const subcircuitComponentsByName = new Map<string, PrimitiveComponent[]>()
+
+      for (const child of this.children) {
+        // Skip if child is itself a subcircuit
+        if ((child as any).isSubcircuit) continue
+
+        if (child._parsedProps.name) {
+          const components =
+            subcircuitComponentsByName.get(child._parsedProps.name) || []
+          components.push(child)
+          subcircuitComponentsByName.set(child._parsedProps.name, components)
+        }
+      }
+
+      for (const [name, components] of subcircuitComponentsByName.entries()) {
+        if (components.length > 1) {
+          db.pcb_trace_error.insert({
+            error_type: "pcb_trace_error",
+            message: `Multiple components found with name "${name}" in subcircuit "${this._parsedProps.name || "unnamed"}". Component names must be unique within a subcircuit.`,
+            source_trace_id: "",
+            pcb_trace_id: "",
+            pcb_component_ids: components
+              .map((c) => c.pcb_component_id!)
+              .filter(Boolean),
+            pcb_port_ids: [],
+          })
+        }
+      }
+    }
+  }
 }

tests/repros/repro12-same-name-of-components.test.tsx

@@ -0,0 +1,96 @@
+import { getTestFixture } from "tests/fixtures/get-test-fixture"
+import { test } from "bun:test"
+import { expect } from "bun:test"
+test("repro-12: same name of components in subcircuit", async () => {
+  const { circuit } = getTestFixture()
+
+  circuit.add(
+    <group subcircuit>
+      <resistor resistance="1k" footprint="0402" name="R1" schX={3} pcbX={3} />
+      <resistor
+        resistance="1k"
+        footprint="0402"
+        name="R1"
+        schX={-3}
+        pcbX={-3}
+      />
+      <trace from=".R1 > .pin1" to=".R1 > .pin1" />
+    </group>,
+  )
+
+  await circuit.renderUntilSettled()
+
+  const pcb_trace_errors = circuit.db.pcb_trace_error.list()
+  expect(pcb_trace_errors).toHaveLength(1)
+})
+
+test("repro-12: same name of components in board", async () => {
+  const { circuit } = getTestFixture()
+
+  circuit.add(
+    <board width="10mm" height="10mm">
+      <resistor resistance="1k" footprint="0402" name="R1" schX={3} pcbX={3} />
+      <resistor
+        resistance="1k"
+        footprint="0402"
+        name="R1"
+        schX={-3}
+        pcbX={-3}
+      />
+      <trace from=".R1 > .pin1" to=".R1 > .pin1" />
+    </board>,
+  )
+
+  await circuit.renderUntilSettled()
+
+  const pcb_trace_errors = circuit.db.pcb_trace_error.list()
+  expect(pcb_trace_errors).toHaveLength(1)
+})
+
+test("repro-12: same name of components in different subcircuits should not be an error", async () => {
+  const { circuit } = getTestFixture()
+
+  circuit.add(
+    <group>
+      <group subcircuit>
+        <resistor
+          resistance="1k"
+          footprint="0402"
+          name="R1"
+          schX={3}
+          pcbX={3}
+        />
+        <resistor
+          resistance="1k"
+          footprint="0402"
+          name="R2"
+          schX={-3}
+          pcbX={-3}
+        />
+        <trace from=".R1 > .pin1" to=".R1 > .pin1" />
+      </group>
+      <subcircuit>
+        <resistor
+          resistance="1k"
+          footprint="0402"
+          name="R1"
+          schX={3}
+          pcbX={3}
+        />
+        <resistor
+          resistance="1k"
+          footprint="0402"
+          name="R2"
+          schX={-3}
+          pcbX={-3}
+        />
+      </subcircuit>
+    </group>,
+  )
+
+  await circuit.renderUntilSettled()
+
+  // No errors because the components are in different subcircuits
+  const pcb_trace_errors = circuit.db.pcb_trace_error.list()
+  expect(pcb_trace_errors).toHaveLength(0)
+})