fix: same name of the components should add an error to the circuit json #724
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const errors = checkEachPcbTraceNonOverlapping(db.toArray()) | ||
| for (const error of errors) { | ||
| db.pcb_trace_error.insert(error) | ||
| } |
There was a problem hiding this comment.
I think we want to only run this on the board, because DRC requirements are board-wide, it is a bit of an unusual case but i do think ots correct to have it on board
| const { db } = this.root! | ||
|
|
||
| if (this.isSubcircuit) { | ||
| const subcircuitComponentsByName = new Map<string, PrimitiveComponent[]>() |
There was a problem hiding this comment.
Subcircuit component name checking is good 👍 this one doesnt need to go on the board
There was a problem hiding this comment.
So, we don't need to check it here in Board. But we will have to import from the Group class for this behaviour to be accepted, right?
There was a problem hiding this comment.
You can call the super method inside the board so that it runs the DRC checks that run for any subcircuit. You can alternatively create an internal underscore function that does what the subcircuit does. For example _checkForConflictingNames()
| pcbX={-3} | ||
| /> | ||
| </subcircuit> | ||
| </group>, |
There was a problem hiding this comment.
This is a valid circuit that shouldnt error. Names must be unique within a subcircuit
There was a problem hiding this comment.
It doesn't I am checking for the pcb_trace_error to be 0, will update the test name to be clear.
/close #723