Skip to content

Update main and CI ECM set #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

Update main and CI ECM set #528

merged 3 commits into from
Oct 2, 2025

Conversation

jtlangevin
Copy link
Collaborator

  • The main ECM set in ./ecm_definitions was updated to be consistent with the latest Buildings Sector Scenarios (BSS) data; dual fuel measures and measures that add heat pumps to homes without existing cooling are excluded since those features are not yet available on the master branch. Once those features are added, these measures will be too.
  • The integration testing YAML was updated to pull from a subset of these ECMs that is stored in a new folded off ./ecm_definitions, 'integration_testing'. These integration testing ECMs only apply to a subset of 9 states (one per Census Division) to further speed up processing. Results from running the integration testing YAML in batch replace the existing CI testing results.
  • Supporting updates were made to some of the technology names in ecm_prep and run and to the issue where batch runs don't exclude individual envelope measures in packages from competition in run.py (closes Batch runs ignore inactive or skipped ECMs #512).

@jtlangevin
Update main and CI ECM set
4b6f224 
* The main ECM set in ./ecm_definitions was updated to be consistent with the latest Buildings Sector Scenarios (BSS) data; dual fuel measures and measures that add heat pumps to homes without existing cooling are excluded since those features are not yet available on the master branch. Once those features are added, these measures will be too.
* The integration testing YAML was updated to pull from a subset of these ECMs that is stored in a new folded off ./ecm_definitions, 'integration_testing'. These integration testing ECMs only apply to a subset of 9 states (one per Census Division) to further speed up processing. Results from running the integration testing YAML in batch replace the existing CI testing results.
* Supporting updates were made to some of the technology names in ecm_prep and run and to the issue where batch runs don't exclude individual envelope measures in packages from competition in run.py (closes #512).
aspeake
aspeake approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@aspeake aspeake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My commit avoids reporting changes for on-site generation as that would require a different schema for the report. I added back the technical potential results manually as they were not re-committed by the CI. Good to go once tests pass.

@aspeake aspeake merged commit 611c105 into master Oct 2, 2025
9 checks passed
@aspeake aspeake deleted the ci-ecms branch October 2, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspeake aspeake aspeake approved these changes

@trynthink trynthink Awaiting requested review from trynthink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch runs ignore inactive or skipped ECMs
2 participants
@jtlangevin @aspeake