Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132661 / 25.04 / Move 2FA text #11295

Merged
merged 1 commit into from
Jan 7, 2025
Merged

NAS-132661 / 25.04 / Move 2FA text #11295

merged 1 commit into from
Jan 7, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 6, 2025

Changes:

Instead of showing a snackbar, shows text in-line.

Снимок экрана 2025-01-06 в 18 32 32

@undsoft undsoft requested a review from a team as a code owner January 6, 2025 23:34
@undsoft undsoft requested review from bvasilenko and removed request for a team January 6, 2025 23:34
@bugclerk
Copy link
Contributor

bugclerk commented Jan 6, 2025

@bugclerk bugclerk changed the title NAS-132661: Move 2FA text NAS-132661 / 25.04 / Move 2FA text Jan 6, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (9e50429) to head (fc04d67).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../pages/signin/signin-form/signin-form.component.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11295   +/-   ##
=======================================
  Coverage   82.55%   82.56%           
=======================================
  Files        1658     1658           
  Lines       59114    59110    -4     
  Branches     6215     6215           
=======================================
  Hits        48803    48803           
+ Misses      10311    10307    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@undsoft undsoft merged commit 247cab3 into master Jan 7, 2025
8 of 9 checks passed
@undsoft undsoft deleted the NAS-132661 branch January 7, 2025 15:45
@bugclerk
Copy link
Contributor

bugclerk commented Jan 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants