NAS-132661: Move 2FA text (#11295)

truenas · Jan 7, 2025 · 247cab3 · 247cab3
1 parent 7ab0907
commit 247cab3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/app/pages/signin/signin-form/signin-form.component.html b/src/app/pages/signin/signin-form/signin-form.component.html
@@ -39,6 +39,10 @@
     }
   }
   @if (hasTwoFactor) {
+    <p>
+      {{ '2FA has been configured for this account. Enter the OTP to continue.' | translate }}
+    </p>
+
     <ix-input
       formControlName="otp"
       autocomplete="one-time-code"

diff --git a/src/app/pages/signin/signin-form/signin-form.component.ts b/src/app/pages/signin/signin-form/signin-form.component.ts
@@ -138,17 +138,15 @@ export class SigninFormComponent implements OnInit {
   private handleFailedLogin(loginResult: LoginResult): void {
     this.isLastLoginAttemptFailed = true;
 
-    switch (loginResult) {
-      case LoginResult.NoAccess:
-        this.lastLoginError = this.translate.instant('User is lacking permissions to access WebUI.');
-        break;
-      case LoginResult.NoOtp:
-        this.hasTwoFactor = true;
-        this.lastLoginError = this.translate.instant('2FA has been configured for this account. Enter the OTP to continue.');
-        break;
-      default:
-        this.lastLoginError = this.translate.instant('Wrong username or password. Please try again.');
-        break;
+    if (loginResult === LoginResult.NoOtp) {
+      this.hasTwoFactor = true;
+      return;
+    }
+
+    if (loginResult === LoginResult.NoAccess) {
+      this.lastLoginError = this.translate.instant('User is lacking permissions to access WebUI.');
+    } else {
+      this.lastLoginError = this.translate.instant('Wrong username or password. Please try again.');
     }
 
     this.cdr.markForCheck();