MAIN B-22451 v2 #14843
Merged
MAIN B-22451 v2 #14843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
danieljordan-caci
requested review from
TevinAdams,
cameroncaci and
traskowskycaci
Closed
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
traskowskycaci
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Matches for the most part, if I had questions I checked current integrationTesting to see what was there
TevinAdams
approved these changes
Feb 19, 2025
cameroncaci
approved these changes
Feb 19, 2025
Merged
|
soon...⏳ |
Got hit with a flaky client test so had to restart |
@deandreJones merge queue when |
gitlab... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE This is a second
mainPR due to some issues occurring with the previous from unintended commits/pushesINT PR
INT PR 2
INT PR 3
Previous MAIN PR
NOTE this PR contains the
mainbranch of B-22272-v2 - so ensure it is merged first prior to merging this once POA'dAgility ticket
Summary
Updating the destination queue to consider SIT extension requests with shipments that contain destination SIT service items.
Also adding a ridiculous dump truck amount of testharness cases for testing.
Also updating some inconsistent capitalization in
re_servicesthat was driving me crazy because they weren't consistent with what the rest of the app is doingHow to test
IntlHHGMoveDestSITExtensionRequested(these will show up in the respective dest queues)IntlHHGMoveOriginSITExtensionRequested(these should NOT show up in the dest queue)