B 21941 main v3

[traskowskycaci]

Merge after: #14841
Merge after: #14843

Agility ticket

INT PR: #14810

Test moves:

Please go through the process of making an actual move if you use a test harness move and it's not appearing in the origin or destination queues as expected or acting weird.

I found the test harness moves to not be 100% reliable, so I ended up making my own test moves for these - and will keep the moves locally and can huddle if any questions come up.

This work is to filter moves OUT of the origin TOO queue queue if they have ONLY destination requests. The test will be moves filtered out of the TOO queue, but I threw in what the destination queue behavior should be as an additional check, though this work doesn't touch destination queue logic (those are B-22272 and B-22451).

• One with only destination address update - should NOT appear in TOO queue and should appear in destination queue: 66K9TX
  destination:
  
  origin:
  

• One that has only origin SIT - should appear in TOO queue: HD7746
  destination:
  
  origin:
  

• One that has only dest SIT - should NOT appear in TOO queue and should appear in destination queue: PJJQR7
  destination:
  
  origin:
  

• One that has BOTH origin and dest SIT - should appear in TOO queue and should appear in destination queue: V6PGXF
  destination:
  
  origin:
  

• One that has only domestic origin shuttle - should appear in TOO queue: DJKD8R
  destination:
  
  origin:
  

• One that has only dest shuttle - should NOT appear in TOO queue and should appear in destination queue: 48PX4B
  
  origin:
  

• One that has BOTH origin and dest shuttle - should appear in TOO queue and should appear in destination queue: YM6KHF
  destination:
  
  origin:
  

• One that has only intl origin shuttle - should appear in TOO queue: 9BM93K
  destination:
  
  origin:
  

• One that has only intl destination shuttle - should appear in dest queue: MGR43H
  destination:
  
  origin:
  

• One that has BOTH intl origin and intl dest shuttle - should appear in TOO queue and should appear in destination queue: BMQHX4
  destination:
  
  origin:
  

• One that has excess weight - should appear in TOO queue: KWH4RD
  destination:
  
  origin:
  

• One that has excess UB weight - should appear in TOO queue: QT844H
  destination:
  
  origin:
  

• Test that the moves with excess weight only show up in the expected GBLOC office user TOO queue and not every other GBLOC's TOO queue: (relic of the old query that was an issue but should not be now)
  shown in KKFA queue above
  not in BGNC:
  
  
  not in CCNQ:
  
  

Changes since last review: logic around SIT extensions

• One that has a SIT extension and only origin SIT - should appear in TOO queue: D3PBPJ
  destination:
  
  origin:
  

• One that has a SIT extension and only dest SIT - should appear in dest queue: KCMJVB
  destination:
  
  origin:
  

• One that has a SIT extension and both origin and dest SIT - should appear in both queues: QGFJ7X
  destination:
  
  origin:
  

[traskowskycaci]

Doesn't show up as a changed file on int PR, but is in integrationTesting: https://github.com/transcom/mymove/blob/integrationTesting/pkg/unit/millicents_test.go

[traskowskycaci]

Went into integration with this commit: 9d64856

[cameroncaci]

Poa'd, issue ticket resolutions present, commits are good. There are a bunch of int PRs for this one, but mix in the reverts and the current int pr in the description here is accurate

[danieljordan-caci]

what Cam said - let's send this queue work to the moon