-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-22272 v2 #14841
MAIN B-22272 v2 #14841
Conversation
…cs, add tests, and refine refine refine
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed files match up!
NOTE This is a second
main
PR due to some issues occurring with the previous from unintended commits/pushesINT PR
Previous MAIN PR
HEADS UP - this branch contains the code of B-21583 so please ensure this does not get merged until after that gets in
Agility ticket
Summary
This has been previously tested using our typical queue backend code, but this new BL is using a db function instead with an addition of a
move_to_dest_gbloc
view, which will handle all of the unique affiliation filters we need.This PR has quite a bit of setup so prepare yer butts. Unfortunately the only way to test this thoroughly is to create a metric butt ton of moves.
Per the BL in Agility, we want to add a new "Destination Requests" queue for TOO. This queue will contain moves that are in
Approvals Requested
status and have the following criteria based on the SHIPMENT'S DESTINATION ADDRESS GBLOC, not the destination duty location on the orders:SUBMITTED
status)REQUESTED
status)APPROVALS REQUESTED
statusThere are these exceptions for
USMC
customers (service_members.affiliation
)USMC
moves go into theUSMC
GBLOCThere are these exceptions for
USAF
andSpace Force
customers (service_members.affiliation
)re_rate_areas.name
) it needs to go to theMBFL
GBLOCre_rate_areas.name
), it needs to go to the destination address' respective GBLOCJEAT
GBLOCI would highly advise you to set up a tracker doc (I just used the Mac Notes app) so you can mark which GBLOC the moves should be in, as well as move codes, etc. - here's what I did.
How to test USMC
Destination Requests
tabJEAT
is for AK Zone II &MAPK
is for AK Zone IVHow to test USAF/SF in Alaska Zone II & non-Alaska Zone II
Destination Requests
tabMBFL
TOO, you should see AT A MINIMUM, the Alaska Zone II moves (1 for USAF, 1 for SF)How to test remaining queues
JEAT
GBLOC)JEAT
TOO and view theDestination Requests
tabAdditional testing
Screenshots