B-21941 TOO Queue Filtering For Destination Only Requests- MAIN #14464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an addresses GBLOC not the orders, also need tests and USMC/AF/SF overrides
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
traskowskycaci
changed the title
|
Closing due to polluted git history. Cherry-picked commits into new main and int branch. New main PR here: #14812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream due to writing an excess UB weight test: #14503
Merged in as upstream but then reverted:
original commit for merging in B-21940: 13a59c0
revert to remove the B-21940 changes from this branch: 2b4d5fe
Merged in upstream branches:
22272
main branch: https://github.com/transcom/mymove/tree/MAIN-B-22272
merge commit: Merge remote-tracking branch 'origin/MAIN-B-22272' into B-21941-MAIN-v2
22451
main branch: https://github.com/transcom/mymove/tree/MAIN-B-22451
merge commit: Merge remote-tracking branch 'origin/MAIN-B-22451' into B-21941-MAIN-v2
INT PR
Test moves:
If you use a test harness move and it's not appearing in the origin or destination queues as expected, please go through the process of making an actual move. I found the test harness moves to not be 100% reliable, so I ended up making my own test moves for these - and will keep the moves locally and can huddle if any questions come up.
One with only destination address update - should NOT appear in TOO queue and should appear in destination queue: 66K9TX
destination:
origin:
One that has only origin SIT - should appear in TOO queue
destination: HD7746
origin:
One that has only dest SIT - should NOT appear in TOO queue and should appear in destination queue: PJJQR7
destination:
origin:
destination:
origin:
destination:
origin:
origin:
destination:
origin:
destination:
origin:
destination:
origin:
destination:
origin:
destination:
origin:
destination:
origin:
destination:
origin:
destination:
origin:
One that has excess UB weight - should appear in TOO queue: QT844H
destination:
origin:
Test that the moves with excess weight only show up in the expected GBLOC office user TOO queue and not every other GBLOC's TOO queue: (relic of the old query that was an issue but should not be now)
shown in KKFA queue above
not in BGNC:
not in CCNQ:
Changes since last review: logic around SIT extensions
destination:
origin:
destination:
origin:
destination:
origin:
