transcom · deandreJones · Jan 23, 2025 · Jan 16, 2025 · Jan 7, 2025 · Jan 17, 2025
diff --git a/migrations/app/migrations_manifest.txt b/migrations/app/migrations_manifest.txt
@@ -1073,6 +1073,8 @@
 20241230190647_add_missing_AK_zips_to_zip3_distances.up.sql
 20250103130619_revert_data_change_for_gbloc_for_ak.up.sql
 20250103180420_update_pricing_proc_to_use_local_price_variable.up.sql
+20250106153750_admin_weight_restriction.up.sql
+20250106190758_admin_weight_restriction_convert_bool.up.sql
 20250110001339_update_nts_release_enum_name.up.sql
 20250110153428_add_shipment_address_updates_to_move_history.up.sql
 20250110214012_homesafeconnect_cert.up.sql

diff --git a/migrations/app/schema/20250106153750_admin_weight_restriction.up.sql b/migrations/app/schema/20250106153750_admin_weight_restriction.up.sql
@@ -0,0 +1,2 @@
+ALTER TABLE entitlements
+ADD COLUMN IF NOT EXISTS admin_restricted_weight_location BOOLEAN;
diff --git a/migrations/app/schema/20250106190758_admin_weight_restriction_convert_bool.up.sql b/migrations/app/schema/20250106190758_admin_weight_restriction_convert_bool.up.sql
@@ -0,0 +1,4 @@
+ALTER TABLE entitlements
+ ALTER COLUMN admin_restricted_weight_location TYPE boolean USING (COALESCE(admin_restricted_weight_location, false)),
+ ALTER COLUMN admin_restricted_weight_location SET DEFAULT false,
+ ALTER COLUMN admin_restricted_weight_location SET NOT NULL;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		ALTER TABLE entitlements
		ADD COLUMN IF NOT EXISTS admin_restricted_weight_location BOOLEAN;
Copy link Contributor cameroncaci Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Recommending remove this boolean column and instead basing whether or not the entitlement is restricted based on `entitlements.weight_restriction` being null or not null. Reason for recommendation is because this bool column would just be storing whether or not weight restriction is null or not and also we end up with the possibility of `true` weight restriction without any integer provided Screen.Recording.2025-01-23.at.8.59.38.AM.mov deandreJones reacted with eyes emoji Copy link Contributor Author deandreJones Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Thinking.. im going to read up on the feature and weigh the pros/cons Copy link Contributor Author deandreJones Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @transcom/mountain-movers would also love others thoughts on this Copy link Contributor cameroncaci Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I wouldn't be opposed to just enforcing the constraight of if bool true that weight restriction int must also be present - but we'll want some method of enforcing that a restriction exists Copy link Contributor Author deandreJones Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. actually.. I don't hate it.. refactoring now Copy link Contributor Author deandreJones Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. ill just remove that column and variable, and the UI will read from the weightRestriction value being null or not and if they check it.. they have to enter a value cameroncaci reacted with thumbs up emoji Copy link Contributor danieljordan-caci Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Yeah I agree with this approach! Nice catch Cam! Copy link Contributor traskowskycaci Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Also agree! Seems clean Copy link Contributor Author deandreJones Jan 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. done - give it a re-review I do like this much better