B 21934 int #14629

deandreJones · 2025-01-21T15:52:59Z

B-21934

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Has the branch been pulled in and checked out?
Have the BL acceptance criteria been met for this change?
Was the CircleCI build successful?
Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

Access the Customer app
create a shipment
submit to counselor
login as counselor
search for move that was just created
click Allowances on left side
click on Admin Restricted Weight Location
the weight Restriction box should appear
notice the verbiage change from “Weight allowance” has been changed to “Standard weight allowance”.
add a weight to Weight Restriction and see its saved and viewable on allowances tile
submit the move to TOO(add orders info)
login as TOO search for the move and click approve with shipment(s) selected
on the popup see that the admin restricted weight location value is yes and the weight restriction value is populated
click Approve and send
log in as prime simulator role
in a separate tab go to http://officelocal:3000/swagger-ui/prime.html#/moveTaskOrder/getMoveTaskOrder
review the response in the entitlements object to see that the weight restriction weight is included

Frontend

There are no aXe warnings for UI.
This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
There are no new console errors in the browser devtools.
There are no new console errors in the test output.
If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
This change meets the standards for Section 508 compliance.

Backend

Code follows the guidelines for Logging.
The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

Follows our guidelines for Zero-Downtime Deploys.
Have been communicated to #g-database.
Secure migrations have been tested following the instructions in our docs.

Screenshots

…n' into B-21934-main

danieljordan-caci

Hm... Getting this error when adding orders as the SC:

2025-01-21T23:18:49.729Z        ERROR   ghcapi/orders.go:276    Data received from requester is bad: BAD_DATA: Error saving entitlement {"git_branch": "e-06167-av-polling-int", "git_commit": "eb6f4c304cb43bc605394e17033eb62b18ddd201", "host": "officelocal:3000", "milmove_trace_id": "6a2666f1-4202-422e-adfa-aaa8b854ebe5", "session_id": "p-tva2Q5W5_TJiB41HJEJB2QpysMcqcj9wXuwlAZLqU"}
github.com/transcom/mymove/pkg/handlers/ghcapi.(*CreateOrderHandler).Handle.CreateOrderHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/ghcapi/orders.go:276
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

I did run make db_dev_fresh and start everything fresh. Looks like you might need to add AdminRestrictedWeightLocation to the payload in pkg/handlers/ghcapi/orders.go:262

			entitlement := models.Entitlement{
				DependentsAuthorized:    payload.HasDependents,
				DBAuthorizedWeight:      models.IntPointer(weight),
				StorageInTransit:        models.IntPointer(sitDaysAllowance),
				ProGearWeight:           weightAllotment.ProGearWeight,
				ProGearWeightSpouse:     weightAllotment.ProGearWeightSpouse,
				AccompaniedTour:         payload.AccompaniedTour,
				DependentsUnderTwelve:   dependentsUnderTwelve,
				DependentsTwelveAndOver: dependentsTwelveAndOver,
				UBAllowance:             &weightAllotment.UnaccompaniedBaggageAllowance,
			}

			if saveEntitlementErr := appCtx.DB().Save(&entitlement); saveEntitlementErr != nil {
				err = apperror.NewBadDataError("Error saving entitlement")
				appCtx.Logger().Error(err.Error())
				return orderop.NewCreateOrderUnprocessableEntity(), err
			}

danieljordan-caci · 2025-01-21T23:06:00Z

pkg/handlers/ghcapi/internal/payloads/model_to_payload.go

+		GunSafe:                       gunSafe,
+		AdminRestrictedWeightLocation: adminRestrictedWeightLocation,
+		WeightRestriction:             weightRestriction,
+		ETag:                          etag.GenerateEtag(entitlement.UpdatedAt),


Can you update a test to reflect these changes please?

danieljordan-caci · 2025-01-21T23:06:09Z

pkg/handlers/primeapi/payloads/model_to_payload.go

+		StorageInTransit:  sit,
+		TotalDependents:   totalDependents,
+		TotalWeight:       totalWeight,
+		WeightRestriction: &weightRestriction,
+		ETag:              etag.GenerateEtag(entitlement.UpdatedAt),


Can you update a test to reflect these changes please?

danieljordan-caci · 2025-01-21T23:06:20Z

pkg/services/order/order_updater.go

+	if payload.AdminRestrictedWeightLocation != nil {
+		order.Entitlement.AdminRestrictedWeightLocation = *payload.AdminRestrictedWeightLocation
+	}
+
+	if payload.WeightRestriction != nil {
+		weightRestriction := int(*payload.WeightRestriction)
+		order.Entitlement.WeightRestriction = &weightRestriction
+	}


Can you update a test to reflect these changes please?

danieljordan-caci · 2025-01-21T23:07:43Z

src/components/Office/DefinitionLists/AllowancesList.jsx

+        <div className={visualCuesStyle}>
+          <dt>Admin Restricted Weight Location</dt>
+          <dd data-testid="adminRestrictedWtLoc">{info.adminRestrictedWeightLocation ? 'Yes' : 'No'}</dd>
+        </div>
+        <div className={visualCuesStyle}>
+          <dt>Weight Restriction</dt>
+          <dd data-testid="weightRestriction">
+            {info.weightRestriction ? formatWeight(info.weightRestriction) : DEFAULT_EMPTY_VALUE}
+          </dd>
+        </div>


Can you update a test please?

deandreJones · 2025-01-22T17:25:18Z

Hm... Getting this error when adding orders as the SC:

2025-01-21T23:18:49.729Z        ERROR   ghcapi/orders.go:276    Data received from requester is bad: BAD_DATA: Error saving entitlement {"git_branch": "e-06167-av-polling-int", "git_commit": "eb6f4c304cb43bc605394e17033eb62b18ddd201", "host": "officelocal:3000", "milmove_trace_id": "6a2666f1-4202-422e-adfa-aaa8b854ebe5", "session_id": "p-tva2Q5W5_TJiB41HJEJB2QpysMcqcj9wXuwlAZLqU"}
github.com/transcom/mymove/pkg/handlers/ghcapi.(*CreateOrderHandler).Handle.CreateOrderHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/ghcapi/orders.go:276
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

I did run make db_dev_fresh and start everything fresh. Looks like you might need to add AdminRestrictedWeightLocation to the payload in pkg/handlers/ghcapi/orders.go:262

			entitlement := models.Entitlement{
				DependentsAuthorized:    payload.HasDependents,
				DBAuthorizedWeight:      models.IntPointer(weight),
				StorageInTransit:        models.IntPointer(sitDaysAllowance),
				ProGearWeight:           weightAllotment.ProGearWeight,
				ProGearWeightSpouse:     weightAllotment.ProGearWeightSpouse,
				AccompaniedTour:         payload.AccompaniedTour,
				DependentsUnderTwelve:   dependentsUnderTwelve,
				DependentsTwelveAndOver: dependentsTwelveAndOver,
				UBAllowance:             &weightAllotment.UnaccompaniedBaggageAllowance,
			}

			if saveEntitlementErr := appCtx.DB().Save(&entitlement); saveEntitlementErr != nil {
				err = apperror.NewBadDataError("Error saving entitlement")
				appCtx.Logger().Error(err.Error())
				return orderop.NewCreateOrderUnprocessableEntity(), err
			}

what branch are you on... this works fine for me on my main branch and the int version (B-21934-int)

danieljordan-caci · 2025-01-22T17:27:04Z

Hm... Getting this error when adding orders as the SC:

2025-01-21T23:18:49.729Z        ERROR   ghcapi/orders.go:276    Data received from requester is bad: BAD_DATA: Error saving entitlement {"git_branch": "e-06167-av-polling-int", "git_commit": "eb6f4c304cb43bc605394e17033eb62b18ddd201", "host": "officelocal:3000", "milmove_trace_id": "6a2666f1-4202-422e-adfa-aaa8b854ebe5", "session_id": "p-tva2Q5W5_TJiB41HJEJB2QpysMcqcj9wXuwlAZLqU"}
github.com/transcom/mymove/pkg/handlers/ghcapi.(*CreateOrderHandler).Handle.CreateOrderHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/ghcapi/orders.go:276
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

I did run make db_dev_fresh and start everything fresh. Looks like you might need to add AdminRestrictedWeightLocation to the payload in pkg/handlers/ghcapi/orders.go:262

			entitlement := models.Entitlement{
				DependentsAuthorized:    payload.HasDependents,
				DBAuthorizedWeight:      models.IntPointer(weight),
				StorageInTransit:        models.IntPointer(sitDaysAllowance),
				ProGearWeight:           weightAllotment.ProGearWeight,
				ProGearWeightSpouse:     weightAllotment.ProGearWeightSpouse,
				AccompaniedTour:         payload.AccompaniedTour,
				DependentsUnderTwelve:   dependentsUnderTwelve,
				DependentsTwelveAndOver: dependentsTwelveAndOver,
				UBAllowance:             &weightAllotment.UnaccompaniedBaggageAllowance,
			}

			if saveEntitlementErr := appCtx.DB().Save(&entitlement); saveEntitlementErr != nil {
				err = apperror.NewBadDataError("Error saving entitlement")
				appCtx.Logger().Error(err.Error())
				return orderop.NewCreateOrderUnprocessableEntity(), err
			}

what branch are you on... this works fine for me on my main branch and the int version (B-21934-int)

I was on your branch

deandreJones · 2025-01-22T17:54:27Z

Hm... Getting this error when adding orders as the SC:

2025-01-21T23:18:49.729Z        ERROR   ghcapi/orders.go:276    Data received from requester is bad: BAD_DATA: Error saving entitlement {"git_branch": "e-06167-av-polling-int", "git_commit": "eb6f4c304cb43bc605394e17033eb62b18ddd201", "host": "officelocal:3000", "milmove_trace_id": "6a2666f1-4202-422e-adfa-aaa8b854ebe5", "session_id": "p-tva2Q5W5_TJiB41HJEJB2QpysMcqcj9wXuwlAZLqU"}
github.com/transcom/mymove/pkg/handlers/ghcapi.(*CreateOrderHandler).Handle.CreateOrderHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/ghcapi/orders.go:276
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

I did run make db_dev_fresh and start everything fresh. Looks like you might need to add AdminRestrictedWeightLocation to the payload in pkg/handlers/ghcapi/orders.go:262

			entitlement := models.Entitlement{
				DependentsAuthorized:    payload.HasDependents,
				DBAuthorizedWeight:      models.IntPointer(weight),
				StorageInTransit:        models.IntPointer(sitDaysAllowance),
				ProGearWeight:           weightAllotment.ProGearWeight,
				ProGearWeightSpouse:     weightAllotment.ProGearWeightSpouse,
				AccompaniedTour:         payload.AccompaniedTour,
				DependentsUnderTwelve:   dependentsUnderTwelve,
				DependentsTwelveAndOver: dependentsTwelveAndOver,
				UBAllowance:             &weightAllotment.UnaccompaniedBaggageAllowance,
			}

			if saveEntitlementErr := appCtx.DB().Save(&entitlement); saveEntitlementErr != nil {
				err = apperror.NewBadDataError("Error saving entitlement")
				appCtx.Logger().Error(err.Error())
				return orderop.NewCreateOrderUnprocessableEntity(), err
			}

what branch are you on... this works fine for me on my main branch and the int version (B-21934-int)

I was on your branch

interesting... ill add to that payload, but Im not getting that error- tried a few diff scenarios

danieljordan-caci · 2025-01-22T18:49:08Z

Hm... Getting this error when adding orders as the SC:

2025-01-21T23:18:49.729Z        ERROR   ghcapi/orders.go:276    Data received from requester is bad: BAD_DATA: Error saving entitlement {"git_branch": "e-06167-av-polling-int", "git_commit": "eb6f4c304cb43bc605394e17033eb62b18ddd201", "host": "officelocal:3000", "milmove_trace_id": "6a2666f1-4202-422e-adfa-aaa8b854ebe5", "session_id": "p-tva2Q5W5_TJiB41HJEJB2QpysMcqcj9wXuwlAZLqU"}
github.com/transcom/mymove/pkg/handlers/ghcapi.(*CreateOrderHandler).Handle.CreateOrderHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/ghcapi/orders.go:276
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

I did run make db_dev_fresh and start everything fresh. Looks like you might need to add AdminRestrictedWeightLocation to the payload in pkg/handlers/ghcapi/orders.go:262

			entitlement := models.Entitlement{
				DependentsAuthorized:    payload.HasDependents,
				DBAuthorizedWeight:      models.IntPointer(weight),
				StorageInTransit:        models.IntPointer(sitDaysAllowance),
				ProGearWeight:           weightAllotment.ProGearWeight,
				ProGearWeightSpouse:     weightAllotment.ProGearWeightSpouse,
				AccompaniedTour:         payload.AccompaniedTour,
				DependentsUnderTwelve:   dependentsUnderTwelve,
				DependentsTwelveAndOver: dependentsTwelveAndOver,
				UBAllowance:             &weightAllotment.UnaccompaniedBaggageAllowance,
			}

			if saveEntitlementErr := appCtx.DB().Save(&entitlement); saveEntitlementErr != nil {
				err = apperror.NewBadDataError("Error saving entitlement")
				appCtx.Logger().Error(err.Error())
				return orderop.NewCreateOrderUnprocessableEntity(), err
			}

what branch are you on... this works fine for me on my main branch and the int version (B-21934-int)

I was on your branch

interesting... ill add to that payload, but Im not getting that error- tried a few diff scenarios

Hm. I'll give it another crack.

danieljordan-caci · 2025-01-22T19:13:12Z

Attaching video with server output. DB is fresh, haven't done anything. This happens for CONUS & OCONUS moves created by SC.

Screen.Recording.2025-01-22.at.1.11.52.PM.mov

danieljordan-caci · 2025-01-22T19:15:19Z

Getting this when doing it as the customer:

2025-01-22T19:13:36.304Z        ERROR   internalapi/orders.go:235       Error saving customer entitlement       {"git_branch": "INT-B-21838-payment-request-rejection-reason", "git_commit": "a36f2a2816f69d1a8944c8f10bd2e0bbe9f50104", "host": "milmovelocal:3000", "milmove_trace_id": "e287d902-aa59-4402-8b7f-47416707a6b2", "session_id": "z6ChBPKopzBHF1DPrIBbIVlYZkPgJpIklJfHu4A2UaI", "error": "pq: null value in column \"admin_restricted_weight_location\" of relation \"entitlements\" violates not-null constraint"}
github.com/transcom/mymove/pkg/handlers/internalapi.(*CreateOrdersHandler).Handle.CreateOrdersHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/internalapi/orders.go:235
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

"error": "pq: null value in column \"admin_restricted_weight_location\" of relation \"entitlements\" violates not-null constraint"}

Here's the customer side:

Screen.Recording.2025-01-22.at.1.14.26.PM.mov

traskowskycaci

Worked great for me for the prime v1 getMoveTaskOrder endpoint!

Though I didn't see it come back with the entitlements object for v2 or v3 getMoveTaskOrder calls.
v2:

v3:

deandreJones · 2025-01-22T19:20:55Z

{"git_branch": "INT-B-21838-payment-request-rejection-reason"

Getting this when doing it as the customer:

2025-01-22T19:13:36.304Z        ERROR   internalapi/orders.go:235       Error saving customer entitlement       {"git_branch": "INT-B-21838-payment-request-rejection-reason", "git_commit": "a36f2a2816f69d1a8944c8f10bd2e0bbe9f50104", "host": "milmovelocal:3000", "milmove_trace_id": "e287d902-aa59-4402-8b7f-47416707a6b2", "session_id": "z6ChBPKopzBHF1DPrIBbIVlYZkPgJpIklJfHu4A2UaI", "error": "pq: null value in column \"admin_restricted_weight_location\" of relation \"entitlements\" violates not-null constraint"}
github.com/transcom/mymove/pkg/handlers/internalapi.(*CreateOrdersHandler).Handle.CreateOrdersHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/internalapi/orders.go:235
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

"error": "pq: null value in column \"admin_restricted_weight_location\" of relation \"entitlements\" violates not-null constraint"}

Here's the customer side:

Screen.Recording.2025-01-22.at.1.14.26.PM.mov

{"git_branch": "INT-B-21838-payment-request-rejection-reason"

your branch shows this in the error ^^

deandreJones · 2025-01-22T19:53:17Z

Worked great for me for the prime v1 getMoveTaskOrder endpoint!

Though I didn't see it come back with the entitlements object for v2 or v3 getMoveTaskOrder calls. v2:

v3:

added to v2 and v3 payload

traskowskycaci · 2025-01-22T20:21:20Z

swagger-def/ghc.yaml

really wish we had a linter rule set up for single or double quotes on these yaml files... someday

I do need to add that to my list- thanks for the reminder

traskowskycaci

Seeing it for v2 and v3 now!

danieljordan-caci · 2025-01-22T21:16:27Z

{"git_branch": "INT-B-21838-payment-request-rejection-reason"

Getting this when doing it as the customer:

2025-01-22T19:13:36.304Z        ERROR   internalapi/orders.go:235       Error saving customer entitlement       {"git_branch": "INT-B-21838-payment-request-rejection-reason", "git_commit": "a36f2a2816f69d1a8944c8f10bd2e0bbe9f50104", "host": "milmovelocal:3000", "milmove_trace_id": "e287d902-aa59-4402-8b7f-47416707a6b2", "session_id": "z6ChBPKopzBHF1DPrIBbIVlYZkPgJpIklJfHu4A2UaI", "error": "pq: null value in column \"admin_restricted_weight_location\" of relation \"entitlements\" violates not-null constraint"}
github.com/transcom/mymove/pkg/handlers/internalapi.(*CreateOrdersHandler).Handle.CreateOrdersHandler.Handle.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/internalapi/orders.go:235
github.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1
        /Users/daniel.jordan_cn/mymove/pkg/handlers/config.go:152
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1
        /Users/daniel.jordan_cn/mymove/pkg/appcontext/context.go:67

"error": "pq: null value in column \"admin_restricted_weight_location\" of relation \"entitlements\" violates not-null constraint"}
Here's the customer side:
Screen.Recording.2025-01-22.at.1.14.26.PM.mov

{"git_branch": "INT-B-21838-payment-request-rejection-reason"

your branch shows this in the error ^^

What the.. How weird. Trying again. I was def on your branch. Might be losing my mind.

cameroncaci · 2025-01-23T14:01:33Z

migrations/app/schema/20250106153750_admin_weight_restriction.up.sql

+ALTER TABLE entitlements
+ADD COLUMN IF NOT EXISTS admin_restricted_weight_location BOOLEAN;


Recommending remove this boolean column and instead basing whether or not the entitlement is restricted based on entitlements.weight_restriction being null or not null.

Reason for recommendation is because this bool column would just be storing whether or not weight restriction is null or not and also we end up with the possibility of true weight restriction without any integer provided

Screen.Recording.2025-01-23.at.8.59.38.AM.mov

Thinking.. im going to read up on the feature and weigh the pros/cons

@transcom/mountain-movers would also love others thoughts on this

I wouldn't be opposed to just enforcing the constraight of if bool true that weight restriction int must also be present - but we'll want some method of enforcing that a restriction exists

actually.. I don't hate it.. refactoring now

ill just remove that column and variable, and the UI will read from the weightRestriction value being null or not
and if they check it.. they have to enter a value

Yeah I agree with this approach! Nice catch Cam!

Also agree! Seems clean

done - give it a re-review
I do like this much better

deandreJones and others added 7 commits January 16, 2025 20:02

Merge remote-tracking branch 'origin/b-21938-entitlement-refactor-mai…

9db96ef

…n' into B-21934-main

B-21934

4e79c09

B-21934

13764bc

B-21934

6204fed

Merge branch 'integrationTesting' into B-21934-int

5dbc184

merge conflict fixes

62a3b44

Merge branch 'integrationTesting' into B-21934-int

f88c16a

deandreJones marked this pull request as ready for review January 21, 2025 17:20

deandreJones requested review from a team as code owners January 21, 2025 17:20

deandreJones added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Jan 21, 2025

deandreJones requested review from a team, danieljordan-caci, TevinAdams, cameroncaci and traskowskycaci January 21, 2025 17:20

danieljordan-caci requested changes Jan 21, 2025

View reviewed changes

deandreJones added 2 commits January 22, 2025 12:04

add tests

6f96ae7

Merge remote-tracking branch 'origin/B-21934-main' into B-21934-int2

c1c37b5

deandreJones added 2 commits January 22, 2025 12:32

fix test

0cc7a3a

fix test

9070c36

deandreJones and others added 3 commits January 22, 2025 13:06

fix test add to create orders payload

b4a649f

Merge branch 'integrationTesting' into B-21934-int

0e728d4

test fix

2bd35bd

test fix

c3a23c4

traskowskycaci requested changes Jan 22, 2025

View reviewed changes

deandreJones added 2 commits January 22, 2025 14:47

missing in payload for v2 and 3

a25402d

Merge remote-tracking branch 'origin/B-21934-main' into B-21934-int2

c17a897

deandreJones requested review from traskowskycaci and danieljordan-caci January 22, 2025 19:53

traskowskycaci reviewed Jan 22, 2025

View reviewed changes

traskowskycaci previously approved these changes Jan 22, 2025

View reviewed changes

cameroncaci requested changes Jan 23, 2025

View reviewed changes

deandreJones added 2 commits January 23, 2025 15:51

refactored

5f26682

Merge remote-tracking branch 'origin/B-21934-main' into B-21934-int2

6061c7b

deandreJones dismissed traskowskycaci’s stale review via 6061c7b January 23, 2025 16:14

deandreJones requested a review from cameroncaci January 23, 2025 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

B 21934 int #14629

B 21934 int #14629

deandreJones commented Jan 21, 2025

danieljordan-caci left a comment

danieljordan-caci Jan 21, 2025

danieljordan-caci Jan 21, 2025

danieljordan-caci Jan 21, 2025

danieljordan-caci Jan 21, 2025

deandreJones commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

deandreJones commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

traskowskycaci left a comment

deandreJones commented Jan 22, 2025

deandreJones commented Jan 22, 2025

traskowskycaci Jan 22, 2025

deandreJones Jan 22, 2025

traskowskycaci left a comment

danieljordan-caci commented Jan 22, 2025

cameroncaci Jan 23, 2025

deandreJones Jan 23, 2025

deandreJones Jan 23, 2025

cameroncaci Jan 23, 2025

deandreJones Jan 23, 2025

deandreJones Jan 23, 2025

danieljordan-caci Jan 23, 2025

traskowskycaci Jan 23, 2025

deandreJones Jan 23, 2025

		ALTER TABLE entitlements
		ADD COLUMN IF NOT EXISTS admin_restricted_weight_location BOOLEAN;

B 21934 int #14629

Are you sure you want to change the base?

B 21934 int #14629

Conversation

deandreJones commented Jan 21, 2025

Summary

Verification Steps for the Author

Verification Steps for Reviewers

Setup to Run the Code

How to test

Frontend

Backend

Database

Any new migrations/schema changes:

Screenshots

danieljordan-caci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deandreJones commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

deandreJones commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

danieljordan-caci commented Jan 22, 2025

traskowskycaci left a comment

Choose a reason for hiding this comment

deandreJones commented Jan 22, 2025

deandreJones commented Jan 22, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

traskowskycaci left a comment

Choose a reason for hiding this comment

danieljordan-caci commented Jan 22, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment