Skip to content

improve occlusion culling with transparent pixels #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crosby-moe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve occlusion culling with transparent pixels #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/dev/tr7zw/skinlayers/util/NMSWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public class NMSWrapper {

public static class WrappedNativeImage implements TextureData {

private static final int SOLID_THRESHOLD = 230;
private final NativeImage natImage;

public WrappedNativeImage(NativeImage natImage) {
Expand All @@ -17,12 +18,18 @@ public WrappedNativeImage(NativeImage natImage) {

@Override
public boolean isPresent(UV onTextureUV) {
return natImage.getLuminanceOrAlpha(onTextureUV.u(), onTextureUV.v()) != 0;
byte unsignedAlpha = natImage.getLuminanceOrAlpha(onTextureUV.u(), onTextureUV.v());
int alpha = unsignedAlpha & 0xFF; // convert to int [0, 255]

return alpha > (0xFF - SOLID_THRESHOLD);
}

@Override
public boolean isSolid(UV onTextureUV) {
return natImage.getLuminanceOrAlpha(onTextureUV.u(), onTextureUV.v()) == -1;
byte unsignedAlpha = natImage.getLuminanceOrAlpha(onTextureUV.u(), onTextureUV.v());
int alpha = unsignedAlpha & 0xFF; // convert to int [0, 255]

return alpha > SOLID_THRESHOLD;
}

}
Expand Down