Skip to content

Conversation

@crosby-moe
Copy link

Improves the look of occlusion culling with transparent pixels by considering almost-solid pixels as solid, and almost-invisible pixels as invisible

Before:
Before occlusion culling improvements

After:
After occlusion culling improvements

@what-the-diff
Copy link

what-the-diff bot commented Jul 15, 2025

PR Summary

  • Introduction of New Parameter
    A new constant named SOLID_THRESHOLD has been introduced with a set value of 230. It will serve as a standardized reference in our following changes.

  • Update in Presence Check
    The isPresent method has been improved. Now, it verifies whether the transparency level of a certain element is beyond a particular threshold (255 minus the SOLID_THRESHOLD), thus, improving the way we determine the presence of an element.

  • Enhancement in Solidity Determination
    The isSolid method now measures solidity by checking if the transparency level of an element is above our set SOLID_THRESHOLD. This update will aid in more accurately determining the solidity of an element.

@tr7zw
Copy link
Owner

tr7zw commented Jul 16, 2025

I'm not sure. This is being used as a feature to prevent connections when having patterns like this:
image
turning into
image

@crosby-moe
Copy link
Author

I'm not sure. This is being used as a feature to prevent connections when having patterns like this: image turning into image

From what I can see, this behaviour seems to already be broken using the latest release:

Vanilla

2025-07-16_18 16 07

3d Skin Layers 1.8.1 without patch

2025-07-16_18 13 34

3d Skin Layers 1.8.1 with patch

2025-07-16_18 14 58

@tr7zw
Copy link
Owner

tr7zw commented Jul 17, 2025

No, I mean you place a pixel with 1% transparency into the holes to prevent the mod from closing the corner. The patch would remove this possibility, so it will always look broken with nothing a player can do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants