Repository navigation
🐛 fix(markdown): drop whitespace in link destinations - #1237
Merged
Merged
Conversation
gaborbernat
force-pushed
the
fix/markdown-url-whitespace
branch
from
October 8, 2026 13:47
9234df8 to
0c37ec5
Compare
Merging this PR will regress 1 benchmark
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_feature[prune-shared-single] |
89.1 µs | 96.1 µs | -7.31% |
| ⚡ | test_feature[shadow-slot-comments] |
137.9 µs | 83.2 µs | +65.74% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:fix/markdown-url-whitespace (0c37ec5) with main (af31f20)
Footnotes
-
32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
A destination cannot hold a line ending (CommonMark 6.3), so an href with a newline came out as literal text. The URL parser removes every tab and newline anyway (URL Standard 4.4), so the destination writer leaves them out and the URL stays the same.
gaborbernat
force-pushed
the
fix/markdown-url-whitespace
branch
from
October 8, 2026 15:59
0c37ec5 to
32e53ca
Compare
gaborbernat
added a commit
to gaborbernat/turbohtml
that referenced
this pull request
Oct 8, 2026
On tox-dev#1237's run the summary listed one input and its stack trace as two crashes, both under the fuzzer name "undefined". CIFuzz saves each input as out/artifacts/<target>/<sanitizer>/<input> with an <input>.summary beside it (fuzz_target.py _target_artifact_path and _save_crash). cflite.py read the parent directory, the sanitizer, and counted the summary too. cflite.py now takes the target from the first directory under out/artifacts and skips summary files. A maintainer needs that name to reproduce the crash, and it is not secret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_markdowncopied a tab or line break in a link or image destination into the Markdown.<a href="a\nb">x</a>became[x](a\nb), which reads back as literal text, since no destination form holds a line ending (CommonMark 6.3).The URL parser removes every tab and newline from a URL (URL Standard, basic URL parser), so
a\nbandabname the same URL. The destination writer now leaves them out before it picks the bare or the<...>form, giving[x](ab).markdownify 1.2.3 and html2text 2025.4.15 both write
[x](a\nb).