Repository navigation
🐛 fix(fuzz): name the crashing target in CFLite output - #1239
Merged
Merged
Conversation
On tox-dev#1237's run the summary listed one input and its stack trace as two crashes, both under the fuzzer name "undefined". CIFuzz saves each input as out/artifacts/<target>/<sanitizer>/<input> with an <input>.summary beside it (fuzz_target.py _target_artifact_path and _save_crash). cflite.py read the parent directory, the sanitizer, and counted the summary too. cflite.py now takes the target from the first directory under out/artifacts and skips summary files. A maintainer needs that name to reproduce the crash, and it is not secret.
Merging this PR will degrade performance by 20.06%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_feature[shadow-slot-comments] |
110.3 µs | 138 µs | -20.06% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:fix/cflite-crash-target (5f6c069) with main (d3c6243)
Footnotes
-
32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClusterFuzzLite summary that
tools/fuzz/cflite.pyprints named the sanitizer where it should name the fuzz target, and it listed each crash twice. On #1237's run (37787132229, undefined job) it reported a 46-byte input and a 3840-byte file as two crashes, both with"fuzzer": "undefined", so neither entry named the harness to reproduce.CIFuzz saves each crashing input as
out/artifacts/<target>/<sanitizer>/<input>, with the stack trace in<input>.summarybeside it (_target_artifact_pathand_save_crash).cflite.pytook the file's parent directory, which is the sanitizer, and counted the.summaryfile as a second crash. It now names the first directory underout/artifactsand skips.summaryfiles. The target name is not secret, and the summary still shows only a hash and size for each input.