refactor(react-query): improve cli utils #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People can be co-author:
|
🦋 Changeset detectedLatest commit: 06aa4c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 69 kB ℹ️ View Unchanged
|
CodSpeed Performance ReportMerging #1383 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
+ Coverage 73.86% 75.81% +1.95%
==========================================
Files 69 69
Lines 593 583 -10
Branches 134 128 -6
==========================================
+ Hits 438 442 +4
+ Misses 144 130 -14
Partials 11 11
|
gwansikk
changed the title
gwansikk
commented
Dec 3, 2024
| @@ -10,7 +10,7 @@ export function copy(version: number) { | |||
| return false | |||
| } | |||
|
|
|||
| files.forEach((file) => { | |||
| for (const file of files) { | |||
There was a problem hiding this comment.
This may not have a significant impact on our project, but I agree with the intent and would like to follow it.
ref: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-for-each.md
Comment on lines
6
to
12
| try { | ||
| // eslint-disable-next-line @typescript-eslint/no-require-imports | ||
| return { exports: require(name) as T, isSuccess: true } | ||
| return require(name) as T | ||
| } catch { | ||
| return { exports: undefined, isSuccess: false } | ||
| throw new Error(`${name} is not found.`) | ||
| } | ||
| } |
There was a problem hiding this comment.
Previously, loadModule did not throw errors directly but instead followed a structure where the CLI (node) would terminate at the point where the function was used. However, this approach made testing difficult, as mocking require in Node.js is not possible. For this reason, we decided to modify the utils function to throw errors directly, as it allows for more reliable testing.
P.S. Once this PR is merged, I plan to implement a global error handler for the CLI and custom error classes in the next version.
ref: https://github.com/tj/commander.js?tab=readme-ov-file#override-exit-and-output-handling
manudeli
approved these changes
Dec 7, 2024
manudeli
added a commit
that referenced
this pull request
Dec 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/[email protected] ### Patch Changes - [#1383](#1383) [`2c06c84`](2c06c84) Thanks [@gwansikk](https://github.com/gwansikk)! - refactor(react-query): improve cli utils - Updated dependencies \[]: - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[]: - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[]: - @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected]
1 task
manudeli
added a commit
that referenced
this pull request
Dec 11, 2024
# Overview related: #1383 (comment) - add error handler in commander.js - add logger utils (for consistency) ref: https://github.com/tj/commander.js?tab=readme-ov-file#override-exit-and-output-handling ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closed: #1292
PR Checklist