Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: test coverage 100% for @suspensive/react-query #1292

Closed
manudeli opened this issue Oct 3, 2024 · 8 comments · Fixed by #1383
Closed

[Feature]: test coverage 100% for @suspensive/react-query #1292

manudeli opened this issue Oct 3, 2024 · 8 comments · Fixed by #1383
Assignees
@gwansikk

Comments

@manudeli
Copy link
Member

manudeli commented Oct 3, 2024

Package Scope

@suspensive/react-query

Description

image

Possible Solution

No response

etc.

No response
@coauthors Coauthors
Copy link

coauthors bot commented Oct 3, 2024 •
edited
Loading

People can be co-author:

Candidate Reasons Count Add this as commit message
@saul-atomrigs #1292 (comment) #1292 (comment) #1292 (comment) 3 Co-authored-by: saul-atomrigs <[email protected]>
@gwansikk #1292 (comment) #1292 (comment) #1292 (comment) 3 Co-authored-by: gwansikk <[email protected]>
@manudeli #1292 (comment) #1292 2 Co-authored-by: manudeli <[email protected]>

@saul-atomrigs
Copy link
Contributor

hi, may I contribute to this issue? @gwansikk @manudeli

@gwansikk
Copy link
Collaborator

hi, may I contribute to this issue? @gwansikk @manudeli

Of course!

@manudeli
Copy link
Member Author

Of course!

@gwansikk
Copy link
Collaborator

@saul-atomrigs The project structure of the react-query package may change. Could you wait a bit before starting work?

@saul-atomrigs
Copy link
Contributor

@gwansikk
Thank you for reminder, I'll wait 😄

@gwansikk
Copy link
Collaborator

@saul-atomrigs You can proceed with this task now!

@saul-atomrigs
Copy link
Contributor

Thanks! @gwansikk

@saul-atomrigs saul-atomrigs mentioned this issue Nov 25, 2024
Merged
manudeli pushed a commit that referenced this issue Nov 26, 2024
@saul-atomrigs
test: add tests for react-query package (#1375)
6662e3f 
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

Issue #1292

For now, I managed to add tests for `postinstall.ts` and part of
`package.ts`

### AS-IS
![Captura de pantalla 2024-11-25 a las 6 47 22 p
 m](https://github.com/user-attachments/assets/e27ed362-68fe-4e4b-971e-a43f1715fa28)

### TO-BE
![Captura de pantalla 2024-11-25 a las 6 48 32 p
 m](https://github.com/user-attachments/assets/8f8dc937-4645-482d-987e-6574fa4c13dc)


## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
@gwansikk gwansikk linked a pull request Dec 3, 2024 that will close this issue
refactor(react-query): improve cli utils #1383
Merged
1 task
@gwansikk gwansikk mentioned this issue Dec 3, 2024
Merged
1 task
manudeli added a commit that referenced this issue Dec 7, 2024
@gwansikk @manudeli
refactor(react-query): improve cli utils (#1383)
2c06c84 
# Overview

closed: #1292

- modified the cli utils function to throw errors.
- add tests for react-query (100%)

<img width="500" alt="image"
src="https://github.com/user-attachments/assets/e930d5e5-4663-4648-9912-5941d24345af">

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwansikk gwansikk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(react-query): improve cli utils toss/suspensive
3 participants
@gwansikk @manudeli @saul-atomrigs