test: add tests for `react-query` package #1375

saul-atomrigs · 2024-11-25T09:55:55Z

Overview

Issue #1292

For now, I managed to add tests for postinstall.ts and part of package.ts

AS-IS

TO-BE

PR Checklist

[✅] I did below actions if need

I read the Contributing Guide
I added documents and tests.

changeset-bot · 2024-11-25T09:55:59Z

⚠️ No Changeset found

Latest commit: cba5ef5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coauthors · 2024-11-25T09:56:00Z

People can be co-author:

Candidate	Reasons	Count	Add this as commit message
@manudeli	#1375 (comment) #1375 (comment) #1375 (review) #1375 (review)	4	`Co-authored-by: manudeli <[email protected]>`
@saul-atomrigs	#1375 (comment) #1375	2	`Co-authored-by: saul-atomrigs <[email protected]>`
@codecov-commenter	#1375 (comment)	1	`Co-authored-by: codecov-commenter <[email protected]>`
@gwansikk	#1375 (comment)	1	`Co-authored-by: gwansikk <[email protected]>`

vercel · 2024-11-25T09:56:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2024 1:19am
v1.suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2024 1:19am
visualization.suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2024 1:19am

vercel · 2024-11-25T09:56:05Z

@saul-atomrigs is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

codspeed-hq · 2024-11-25T09:57:46Z

CodSpeed Performance Report

Merging #1375 will create unknown performance changes

_{Comparing saul-atomrigs:test/react-query (cba5ef5) with main (41c7e66)}

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

codecov-commenter · 2024-11-25T09:58:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (41c7e66) to head (cba5ef5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   72.00%   73.86%   +1.85%     
==========================================
  Files          69       69              
  Lines         593      593              
  Branches      134      134              
==========================================
+ Hits          427      438      +11     
+ Misses        153      144       -9     
+ Partials       13       11       -2

Components	Coverage Δ
@suspensive/react	`100.00% <ø> (ø)`
@suspensive/react-dom	`95.55% <ø> (ø)`
@suspensive/react-native	`100.00% <ø> (ø)`
@suspensive/react-query	`82.67% <ø> (+8.66%)`	⬆️
@suspensive/react-query-4	`0.00% <ø> (ø)`
@suspensive/react-query-5	`0.00% <ø> (ø)`
@suspensive/jotai	`0.00% <ø> (ø)`
@suspensive/codemods	`41.97% <ø> (ø)`

manudeli

Thanks for helping me increase my test coverage! I've left a few reviews

manudeli · 2024-11-25T11:47:43Z

packages/react-query/src/bin/postinstall.spec.ts

+  const mockConsoleWarn = vi.spyOn(console, 'warn')
+  const mockGetPackageJson = vi.mocked(getTanStackReactQueryPackageJson)
+  const mockSwitchVersion = vi.mocked(switchVersion)


Long but easy to understand is better in my opinion! because we use too many package.json to name it as mockGetPackageJson

Suggested change

const mockConsoleWarn = vi.spyOn(console, 'warn')

const mockGetPackageJson = vi.mocked(getTanStackReactQueryPackageJson)

const mockSwitchVersion = vi.mocked(switchVersion)

const mockConsoleWarn = vi.spyOn(console, 'warn')

const mockGetTanStackReactQueryPackageJson = vi.mocked(getTanStackReactQueryPackageJson)

const mockSwitchVersion = vi.mocked(switchVersion)

manudeli · 2024-11-25T11:51:12Z

packages/react-query/src/bin/postinstall.spec.ts

+    vi.clearAllMocks()
+  })
+
+  it('should switch to version 4 when TanStack Query v4 is installed', async () => {


In my opinion, It's more easy to understand. Could you reflect this review in your pull request please if you okay?

Suggested change

it('should switch to version 4 when TanStack Query v4 is installed', async () => {

it('should switch to @suspensive/react-query-4 when @tanstack/react-query@^4 is installed', async () => {

…son`

saul-atomrigs · 2024-11-26T01:08:37Z

I applied the changes, thank you for your feedback, @manudeli !

manudeli

@saul-atomrigs Thanks! Let's improve coverage more 👍

gwansikk · 2024-11-26T02:52:19Z

@saul-atomrigs Thanks!

test: add tests for react-query package

b4356c1

saul-atomrigs requested a review from manudeli as a code owner November 25, 2024 09:55

github-actions bot added the @suspensive/react-query label Nov 25, 2024

vercel bot deployed to Preview – visualization.suspensive.org November 25, 2024 09:57 View deployment

vercel bot deployed to Preview – v1.suspensive.org November 25, 2024 09:58 View deployment

vercel bot deployed to Preview – suspensive.org November 25, 2024 10:09 View deployment

manudeli reviewed Nov 25, 2024

View reviewed changes

saul-atomrigs added 2 commits November 26, 2024 10:02

test: rename mock function name to `mockGetTanStackReactQueryPackageJ…

fbe65c3

…son`

test: change sentences

cba5ef5

vercel bot deployed to Preview – v1.suspensive.org November 26, 2024 01:05 View deployment

vercel bot deployed to Preview – visualization.suspensive.org November 26, 2024 01:07 View deployment

manudeli self-requested a review November 26, 2024 01:17

manudeli approved these changes Nov 26, 2024

View reviewed changes

vercel bot deployed to Preview – suspensive.org November 26, 2024 01:19 View deployment

manudeli merged commit 6662e3f into toss:main Nov 26, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add tests for `react-query` package #1375

test: add tests for `react-query` package #1375

saul-atomrigs commented Nov 25, 2024

changeset-bot bot commented Nov 25, 2024 •

edited

Loading

coauthors bot commented Nov 25, 2024 •

edited

Loading

vercel bot commented Nov 25, 2024 •

edited

Loading

vercel bot commented Nov 25, 2024

codspeed-hq bot commented Nov 25, 2024 •

edited

Loading

codecov-commenter commented Nov 25, 2024 •

edited

Loading

manudeli left a comment

manudeli Nov 25, 2024

manudeli Nov 25, 2024

saul-atomrigs commented Nov 26, 2024

manudeli left a comment

gwansikk commented Nov 26, 2024

	it('should switch to version 4 when TanStack Query v4 is installed', async () => {
	it('should switch to @suspensive/react-query-4 when @tanstack/react-query@^4 is installed', async () => {

test: add tests for react-query package #1375

test: add tests for react-query package #1375

Conversation

saul-atomrigs commented Nov 25, 2024

Overview

AS-IS

TO-BE

PR Checklist

changeset-bot bot commented Nov 25, 2024 • edited Loading

⚠️ No Changeset found

coauthors bot commented Nov 25, 2024 • edited Loading

People can be co-author:

vercel bot commented Nov 25, 2024 • edited Loading

vercel bot commented Nov 25, 2024

codspeed-hq bot commented Nov 25, 2024 • edited Loading

CodSpeed Performance Report

Merging #1375 will create unknown performance changes

Summary

codecov-commenter commented Nov 25, 2024 • edited Loading

Codecov Report

manudeli left a comment

Choose a reason for hiding this comment

manudeli Nov 25, 2024

Choose a reason for hiding this comment

manudeli Nov 25, 2024

Choose a reason for hiding this comment

saul-atomrigs commented Nov 26, 2024

manudeli left a comment

Choose a reason for hiding this comment

gwansikk commented Nov 26, 2024

test: add tests for `react-query` package #1375

test: add tests for `react-query` package #1375

changeset-bot bot commented Nov 25, 2024 •

edited

Loading

coauthors bot commented Nov 25, 2024 •

edited

Loading

vercel bot commented Nov 25, 2024 •

edited

Loading

codspeed-hq bot commented Nov 25, 2024 •

edited

Loading

codecov-commenter commented Nov 25, 2024 •

edited

Loading