Use informal address in German and Dutch translations#124
Conversation
WalkthroughUpdated documentation and translation files to strengthen warnings against enabling the inverse_forwarding setting. Added explicit advisories stating this feature should not be enabled unless absolutely necessary and that bug reports submitted with this setting enabled will be closed immediately. Made minor language formality adjustments in some translations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
README.md (1)
48-50: Consider softening/clarifying the “bug reports … will be closed immediately” policy language.
It’s clear, but also unusually adversarial for user docs; if the intent is “unsupported configuration”, something like “bug reports with this enabled may be closed as unsupported” (or “won’t be investigated”) often lands better while preserving the boundary.Also applies to: 174-177
hassio-addon/translations/it.yaml (1)
5-7: IT copy is very long for the UI; consider shortening while keeping the warning.
E.g., keep the first sentence + one short warning sentence, to improve scanability in the add-on config screen.hassio-addon/translations/nl.yaml (1)
7-7: NL Line 7 reads a bit awkward (“keert … om”); consider a more natural phrasing.
Possible alternative: “Indien ingeschakeld, draait dit de doorstuurrichting voor alle apparaten om …”.hassio-addon/translations/de.yaml (1)
7-7: DE Line 7: wording is understandable, but slightly non-idiomatic (“du weißt absolut, was du tust”).
Consider “… es sei denn, du weißt genau, was du tust.” (or “außer du weißt genau …”).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
README.mdhassio-addon/translations/de.yamlhassio-addon/translations/en.yamlhassio-addon/translations/it.yamlhassio-addon/translations/nl.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-addon (linux/arm64)
- GitHub Check: build (linux/arm64)
🔇 Additional comments (4)
README.md (1)
48-50: Confirm scope: PR objectives say “only translation string changes”, but README is also updated.
If intended, consider reflecting that in the PR description/objectives to avoid review/merge surprises.hassio-addon/translations/nl.yaml (1)
10-10: Informal “Je/je” updates look consistent and correct.Also applies to: 13-13
hassio-addon/translations/en.yaml (1)
7-7: EN Line 7: verify the “Bug reports … will be closed immediately” statement matches your actual support policy.
If not strictly enforced, consider “may be closed as unsupported” to avoid over-promising enforcement.hassio-addon/translations/de.yaml (1)
10-10: DE informal tone (“deinem Konto”) looks consistent with the PR goal.
Motivation
inverse_forwardingwarning and account field descriptions.Description
hassio-addon/translations/de.yamlto use informal German phrasing forinverse_forwarding,username, andpassworddescriptions.hassio-addon/translations/nl.yamlto use informal Dutch phrasing forinverse_forwarding,username, andpassworddescriptions.Testing
Codex Task
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.