Skip to content

Use informal address in German and Dutch translations#124

Merged
tomquist merged 1 commit intomainfrom
update-inverse_forwarding-settings-warning
Feb 5, 2026
Merged

Use informal address in German and Dutch translations#124
tomquist merged 1 commit intomainfrom
update-inverse_forwarding-settings-warning

Conversation

@tomquist
Copy link
Owner

@tomquist tomquist commented Jan 11, 2026

Motivation

  • Make the Home Assistant add-on strings use informal address in languages where "Du/je" is appropriate.
  • Apply the requested localization change for the inverse_forwarding warning and account field descriptions.
  • Improve consistency of user-facing tone across translations.

Description

  • Updated hassio-addon/translations/de.yaml to use informal German phrasing for inverse_forwarding, username, and password descriptions.
  • Updated hassio-addon/translations/nl.yaml to use informal Dutch phrasing for inverse_forwarding, username, and password descriptions.
  • These changes only modify translation strings and do not alter runtime behavior.

Testing

  • No automated tests were run for these documentation/translation changes.

Codex Task

Summary by CodeRabbit

  • Documentation
    • Added and strengthened cautionary guidance against enabling the inverse_forwarding feature across README and multiple language translations.
    • Updated translations (German, Italian, Dutch) with improved language consistency and tone refinements.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 11, 2026

Walkthrough

Updated documentation and translation files to strengthen warnings against enabling the inverse_forwarding setting. Added explicit advisories stating this feature should not be enabled unless absolutely necessary and that bug reports submitted with this setting enabled will be closed immediately. Made minor language formality adjustments in some translations.

Changes

Cohort / File(s) Summary
Documentation
README.md
Strengthened warnings against enabling inverse_forwarding in both main documentation and Advanced Docker Configuration section, emphasizing that bug reports with this setting enabled will be closed
Translations - Inverse Forwarding Warnings
hassio-addon/translations/en.yaml, hassio-addon/translations/de.yaml, hassio-addon/translations/it.yaml, hassio-addon/translations/nl.yaml
Updated inverse_forwarding descriptions across all language translations with stronger cautionary language and explicit note that bug reports will be closed if this setting is enabled; removed trailing blank lines
Translations - Formality Adjustments
hassio-addon/translations/de.yaml, hassio-addon/translations/nl.yaml
Adjusted formal to informal language addressing (changed "Ihr"/"Uw" to "dein"/"Je") in username and password field descriptions

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting formal address (Sie/Uw) to informal address (Du/je) in German and Dutch translations. This is the primary focus of the PR across multiple translation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
README.md (1)

48-50: Consider softening/clarifying the “bug reports … will be closed immediately” policy language.
It’s clear, but also unusually adversarial for user docs; if the intent is “unsupported configuration”, something like “bug reports with this enabled may be closed as unsupported” (or “won’t be investigated”) often lands better while preserving the boundary.

Also applies to: 174-177

hassio-addon/translations/it.yaml (1)

5-7: IT copy is very long for the UI; consider shortening while keeping the warning.
E.g., keep the first sentence + one short warning sentence, to improve scanability in the add-on config screen.

hassio-addon/translations/nl.yaml (1)

7-7: NL Line 7 reads a bit awkward (“keert … om”); consider a more natural phrasing.
Possible alternative: “Indien ingeschakeld, draait dit de doorstuurrichting voor alle apparaten om …”.

hassio-addon/translations/de.yaml (1)

7-7: DE Line 7: wording is understandable, but slightly non-idiomatic (“du weißt absolut, was du tust”).
Consider “… es sei denn, du weißt genau, was du tust.” (or “außer du weißt genau …”).

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c35acc and 020c941.

📒 Files selected for processing (5)
  • README.md
  • hassio-addon/translations/de.yaml
  • hassio-addon/translations/en.yaml
  • hassio-addon/translations/it.yaml
  • hassio-addon/translations/nl.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-addon (linux/arm64)
  • GitHub Check: build (linux/arm64)
🔇 Additional comments (4)
README.md (1)

48-50: Confirm scope: PR objectives say “only translation string changes”, but README is also updated.
If intended, consider reflecting that in the PR description/objectives to avoid review/merge surprises.

hassio-addon/translations/nl.yaml (1)

10-10: Informal “Je/je” updates look consistent and correct.

Also applies to: 13-13

hassio-addon/translations/en.yaml (1)

7-7: EN Line 7: verify the “Bug reports … will be closed immediately” statement matches your actual support policy.
If not strictly enforced, consider “may be closed as unsupported” to avoid over-promising enforcement.

hassio-addon/translations/de.yaml (1)

10-10: DE informal tone (“deinem Konto”) looks consistent with the PR goal.

@tomquist tomquist merged commit 317d354 into main Feb 5, 2026
27 of 28 checks passed
@tomquist tomquist deleted the update-inverse_forwarding-settings-warning branch February 5, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant