Skip to content

feat: select/deselect all languages in translations language selector #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aditya-mitra wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −8
Open

feat: select/deselect all languages in translations language selector #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion webapp/src/component/common/form/LanguagesSelect/getLanguagesContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ export const getLanguagesContent = ({
);

// Показываем кнопки "All" и "None" только для batch операций
const isBatchOperation = context === 'batch-operations';
const isBatchOperation =
context === 'batch-operations' || context === 'translations';

const languageItems = languages.map((lang) => (
<MenuItem
Expand Down
1 change: 1 addition & 0 deletions webapp/src/views/projects/translations/TranslationHeader/TranslationControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export const TranslationControls: React.FC<Props> = ({ onDialogOpen }) => {
value={selectedLanguages || []}
languages={languages || []}
context="translations"
enableEmpty
/>
<ButtonGroup>
<StyledToggleButton
Expand Down
17 changes: 10 additions & 7 deletions webapp/src/views/projects/translations/context/services/useTranslationsService.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,15 @@ export const useTranslationsService = (props: Props) => {
onSuccess(data) {
const flatKeys = flattenKeys(data);

const selectedLanguages = languages?.length
? shaveBy(
data.pages[0].selectedLanguages.map((l) => l.tag),
languages
)
: data.pages[0].selectedLanguages.map((l) => l.tag);
const selectedLanguages =
languages !== undefined
? languages.length === 0
? []
: shaveBy(
data.pages[0].selectedLanguages.map((l) => l.tag),
languages
)
: data.pages[0].selectedLanguages.map((l) => l.tag);
if (query.languages?.toString() !== selectedLanguages?.toString()) {
// update language selection to the fetched one
// if there are some languages which are not permitted or were deleted
Expand Down Expand Up @@ -301,7 +304,7 @@ export const useTranslationsService = (props: Props) => {
}
// override url languages
setUrlLanguages(undefined);
_setLanguages(value?.length ? value : undefined);
_setLanguages(value);
};

const updateQuery = (q: Partial<typeof query>) => {
Expand Down
Loading