-
-
Notifications
You must be signed in to change notification settings - Fork 319
feat: select/deselect all languages in translations language selector #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis PR enables users to deselect all languages in the translation view by expanding batch-operation controls ("All" and "None" buttons) to the translations context, adding an Changes
Sequence DiagramsequenceDiagram
actor User
participant LanguagesSelect as LanguagesSelect<br/>(UI Component)
participant Service as useTranslationsService<br/>(State)
User->>LanguagesSelect: Clicks "None" button
Note over LanguagesSelect: Batch deselection triggered<br/>(enabled by getLanguagesContent<br/>condition expansion)
LanguagesSelect->>LanguagesSelect: Set selectedLanguages = []<br/>(enableEmpty allows empty selection)
LanguagesSelect->>Service: Pass empty array []
Service->>Service: languages.length === 0<br/>→ Return []<br/>(preserve empty, don't default)
Service->>Service: setLanguages([])
Note over Service: Empty array persisted<br/>(not coerced to undefined)
Service-->>User: Updated state reflects<br/>no selected languages
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (3)webapp/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
webapp/**/*.tsx📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,kt,kts}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks! Looks cool. @ZuzanaOdstrcilova, can you check it? |
|
One thing comes into my mind and that's we have limit that only 10 languages can be selected in the same time. Doesn't it break when I select all? |
Let me give it a try today and find out |
|
Hey Aditya, I like your ideas, but unfortunately, there's a limit of 10 languages. Someone already asked us about this. We will discuss it internally and let you know. Thank you:) |
Allow to select all and deselect all when in the translations multi-selector.
feat.mp4
closes #3336
Summary by CodeRabbit
Release Notes
New Features
✏️ Tip: You can customize this high-level summary in your review settings.