Skip to content

fix(mirror): resolve PC-to-Discord message detection & channel routing (#148) - #231

Draft
dgomez407 wants to merge 7 commits into
tokyoweb3:mainfrom
dgomez407:fix/mirror-function
Draft

fix(mirror): resolve PC-to-Discord message detection & channel routing (#148)#231
dgomez407 wants to merge 7 commits into
tokyoweb3:mainfrom
dgomez407:fix/mirror-function

Conversation

@dgomez407

Copy link
Copy Markdown
Contributor

This PR fixes Issue #148 where messages typed directly in the Antigravity IDE on a PC were not being mirrored back to Discord/Telegram despite /mirror being turned ON.

Root Cause Analysis

  1. DOM Selector Scope: UserMessageDetector (src/services/userMessageDetector.ts) relied on a strict .bg-input.p-2 selector. In modern Antigravity / Cascade builds, user message container classes vary (e.g. bg-gray-500/15 p-2, div[class*="bg-input"], [data-message-author-role="user"]), causing DOM detection to return null.
  2. Channel Resolution Fallback: In JoinCommandHandler.routeMirroredMessage (src/commands/joinCommandHandler.ts), detected messages were routed strictly via chatSessionRepo.findByDisplayName(projectName, chatTitle). If a session title was unmapped or a user enabled /mirror in a project channel without creating a dedicated session sub-channel via /join, findByDisplayName returned null and the message was silently dropped.

Fixes Implemented

1. Robust User Message DOM Detection

  • Updated DETECT_USER_MESSAGE_SCRIPT in src/services/userMessageDetector.ts to query all user bubble selector candidates:
    const bubbles = Array.from(scope.querySelectorAll(
        '.bg-input.p-2, div[class*="bg-gray-"][class*="p-2"], div[class*="bg-input"], [data-message-author-role="user"]'
    ));

2. Workspace Channel Fallback Routing

  • Updated JoinCommandHandler.routeMirroredMessage in src/commands/joinCommandHandler.ts to fall back to the project's workspace channel (bridge.approvalChannelByWorkspace.get(projectName)) when findByDisplayName yields null:
    const session = this.chatSessionRepo.findByDisplayName(projectName, chatTitle);
    let targetChannelId = session?.channelId;
    
    if (!targetChannelId && bridge) {
        const workspaceChannel = bridge.approvalChannelByWorkspace.get(projectName);
        if (workspaceChannel) {
            targetChannelId = workspaceChannel.id;
        }
    }

Verification & Test Results

  • Unit Tests:
    • tests/commands/joinCommandHandler.test.ts: Added test verifying workspace channel fallback routing (12/12 tests passing).
    • tests/services/userMessageDetector.test.ts: Verified DOM detector and deduplication (11/11 tests passing).
  • Full Test Suite: npm test executed with 115 test suites passed (1,558 tests passed, 0 failures).

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 545f77b6-bb41-4b84-9449-1dc6f7cfab09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dgomez407

Copy link
Copy Markdown
Contributor Author

Will pause till prior stacked PRs get merged.

@dgomez407
dgomez407 force-pushed the fix/mirror-function branch 2 times, most recently from e5dd1bd to af3716a Compare August 8, 2026 21:08
…d i18n (tokyoweb3#147)

### Audit Summary Matrix: Issue tokyoweb3#147

| # | Item Description | Initial Audit | Resolution Status | Technical Action Taken |
|---|---|:---:|:---:|---|
| 1 | Type Safety in interactionCreateHandler.ts | Still Present | Fixed & Verified | Removed (interaction as any).channelId and (interaction as any).channel?.threads casts; refactored targetChannel checks to use typed sendableChannel in src/events/interactionCreateHandler.ts. |
| 2 | Dependency Injection (ArtifactService) | Still Present | Fixed & Verified | Replaced new ArtifactService() inline instantiation with deps.artifactService || new ArtifactService() in src/events/interactionCreateHandler.ts. |
| 3 | API Consistency (artifactRenderMode?) | Resolved | Confirmed | Verified UserPreferenceRecord.artifactRenderMode is optional (?) in src/database/userPreferenceRepository.ts. |
| 4 | Encoding Robustness (encodeSelectValue) | Still Present | Fixed & Verified | Replaced numeric filename hash with an 8-character hex SHA-256 hash segment of conversationId + filename in src/services/artifactService.ts. |
| 5 | i18n Integration (artifactsUi.ts) | Still Present | Fixed & Verified | Replaced unlocalized strings with t() i18n helper function across UI elements in src/ui/artifactsUi.ts. |

### Technical Details
- Type Safety: Cleaned up interactionCreateHandler.ts by using typed channel property guards and interaction.channelId directly.
- Dependency Injection: Injected artifactService into interactionCreateHandler for testability and architectural consistency.
- Encoding Robustness: Updated ArtifactService.encodeSelectValue to compute sha256(conversationId + ':' + filename).slice(0, 8).
- Internationalization: Wrapped artifactsUi.ts strings with t() helper function.
- Tests: Added TDD unit assertions in artifactService.test.ts and interactionCreateHandler.test.ts.

Rebased against doc/docstring-cleanup.
Full test suite passing (115 test suites, 1549 tests).
…r precedence, and negative test assertions

### Audit Summary Matrix: Final Review Resolution

| # | Item Description | Initial Audit | Resolution Status | Technical Action Taken |
|---|---|:---:|:---:|---|
| 1 | Type Safety in interactionCreateHandler.ts | Still Present | Fixed & Verified | Created SendableChannel type guard in src/utils/discordChannelUtils.ts; removed inline `{ send: Function }` and `(interaction.channel as any).send` casts across all fallback send paths. |
| 2 | Process Log Buffer Consolidation | Still Present | Fixed & Verified | Exported createDefaultProcessLogBuffer() factory in src/utils/processLogBuffer.ts to centralize log buffer configuration across Discord and Telegram message handlers. |
| 3 | Title Parsing & Separator Precedence | Still Present | Fixed & Verified | Refined parseProjectNameFromTitle in src/services/cdpService.ts with a 3-tier separator hierarchy (Product Suffix > Em/En Dash > Hyphen). |
| 4 | Negative Test Coverage (decodeSelectValue) | Still Present | Fixed & Verified | Added explicit test case for same 8-char short prefix collision rejection in tests/services/artifactService.test.ts. |
| 5 | Regression Test (sendableChannel) | Still Present | Fixed & Verified | Added unit test asserting SendableChannel target channel dispatching in tests/events/interactionCreateHandler.test.ts. |

### Technical Details
- Type Safety: Isolated Discord sendable channel narrowing into src/utils/discordChannelUtils.ts with isSendableChannel predicate.
- Process Log Buffering: Standardized maxChars, maxEntries, and maxEntryLength tuning via createDefaultProcessLogBuffer().
- Title Parsing: Prioritized em-dash (—) and en-dash (–) over plain hyphens (-) when extracting project names from titles.
- Test Coverage: Added SendableChannel dispatching test in interactionCreateHandler.test.ts and prefix collision test in artifactService.test.ts.

Full test suite passing (115 test suites, 1559 tests).
@dgomez407
dgomez407 force-pushed the fix/mirror-function branch from af3716a to 3d6b9f1 Compare August 10, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Is the mirror function working for you guys? (IDE to Discord sync issue)

1 participant